pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Manfred Koizar <mkoi-pg@aon.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: shridhar_daithankar@persistent.co.in, pgsql-hackers@postgresql.org, pgsql-general <pgsql-general@postgresql.org>
Cc: pgsql-performance@postgresql.org
Subject: Re: [pgsql-performance] Large databases, performance
Date: Wed, 09 Oct 2002 20:09:03 +0200
Message-ID: <hnf8quog5p54tf4tu0i12v00bc6bc9h0f2@4ax.com> (raw)
In-Reply-To: <19697.1034170370@sss.pgh.pa.us>
References: <3D9C3E05.7070906@clearmetrix.com>
	<3DA1A331.21316.F7E742B@localhost>
	<a2n7qu0qen2ne1chalomdgt5n1etgb4uk3@4ax.com>
	<19697.1034170370@sss.pgh.pa.us>

On Wed, 09 Oct 2002 09:32:50 -0400, Tom Lane <tgl@sss.pgh.pa.us>
wrote:
>Coupla quick comments on these:

My first attempt on user types; thanks for the tips.

>These functions are dangerous as written, because they will crash on
>null inputs.  I'd suggest marking them strict in the function
>declarations.

I was not aware of this, just wondered why bpchar routines didn't
crash :-)  Fixed.

>Some attention to volatility declarations (isCachable
>or isImmutable) would be a good idea too.
>Also, it'd be faster and more portable to write the functions with
>version-1 calling conventions.

Done, too.  In the meantime I've found out why it crashed with 7.3:
INSERT INTO pg_opclass  is now obsolete, have to use  CREATE OPERATOR
CLASS ...

Servus
 Manfred



view thread (48+ messages)

Message-ID: <hnf8quog5p54tf4tu0i12v00bc6bc9h0f2@4ax.com>
Permalink:  ../hnf8quog5p54tf4tu0i12v00bc6bc9h0f2@4ax.com/
Also on:    postgresql.org/message-id/hnf8quog5p54tf4tu0i12v00bc6bc9h0f2@4ax.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-sql@postgresql.org
  Cc: mkoi-pg@aon.at, tgl@sss.pgh.pa.us, pgsql-general@postgresql.org, pgsql-performance@postgresql.org
  Subject: Re: [pgsql-performance] Large databases, performance
  In-Reply-To: <hnf8quog5p54tf4tu0i12v00bc6bc9h0f2@4ax.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox