pg.ddx.io  pgsql-testers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Chris Ruprecht <chrrup@gmail.com>
Cc: pgsql-testers@postgresql.org
Subject: Re: 9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols
Date: Mon, 14 Jun 2010 22:12:29 -0400 (EDT)
Message-ID: <201006150212.o5F2CTb08070@momjian.us> (raw)
In-Reply-To: <324A21D0-CC16-4C38-9582-01ED132BBED2@gmail.com>

Chris Ruprecht wrote:
> I'm building the contrib modules and get this:
> 
> gcc -no-cpp-precomp -O3 -fno-common -arch x86_64 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv check.o controldata.o dump.o exec.o file.o function.o info.o option.o page.o pg_upgrade.o relfilenode.o server.o tablespace.o util.o version.o version_old_8_3.o  -L../../src/port -lpgport -L../../src/interfaces/libpq -lpq -L../../src/port -O3 -fno-common -arch x86_64  -Wl,-dead_strip_dylibs  -lpgport -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -lm  -o pg_upgrade
> ld: duplicate symbol _scandir_file_pattern in controldata.o and check.o

Oops.  That global variable was not properly defined;  not sure why none
of the other compilers caught that bug.  Anyway, the attached patch
should fix your problem, and will appear in 9.0 beta3.  Thanks for the
report.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +

Attachments:

/rtmp/diff (text/x-diff, 1.2K) download Index: contrib/pg_upgrade/pg_upgrade.h =================================================================== RCS file: /cvsroot/pgsql/contrib/pg_upgrade/pg_upgrade.h,v retrieving revision 1.7 diff -c -c -r1.7 pg_upgrade.h *** contrib/pg_upgrade/pg_upgrade.h 12 Jun 2010 17:45:28 -0000 1.7 --- contrib/pg_upgrade/pg_upgrade.h 15 Jun 2010 02:01:48 -0000 *************** *** 237,243 **** /* * Global variables */ ! char scandir_file_pattern[MAXPGPATH]; /* check.c */ --- 237,243 ---- /* * Global variables */ ! extern char scandir_file_pattern[]; /* check.c */ Index: contrib/pg_upgrade/relfilenode.c =================================================================== RCS file: /cvsroot/pgsql/contrib/pg_upgrade/relfilenode.c,v retrieving revision 1.3 diff -c -c -r1.3 relfilenode.c *** contrib/pg_upgrade/relfilenode.c 13 May 2010 22:51:00 -0000 1.3 --- contrib/pg_upgrade/relfilenode.c 15 Jun 2010 02:01:48 -0000 *************** *** 17,22 **** --- 17,25 ---- const char *oldnspname, const char *oldrelname, const char *newnspname, const char *newrelname); + /* used by scandir(), must be global */ + char scandir_file_pattern[MAXPGPATH]; + /* * transfer_all_new_dbs() *

view thread (4+ messages)  latest in thread

Message-ID: <201006150212.o5F2CTb08070@momjian.us>
Permalink:  ../201006150212.o5F2CTb08070@momjian.us/
Also on:    postgresql.org/message-id/201006150212.o5F2CTb08070@momjian.us

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-testers@postgresql.org
  Cc: bruce@momjian.us, chrrup@gmail.com
  Subject: Re: 9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols
  In-Reply-To: <201006150212.o5F2CTb08070@momjian.us>
  References: <324A21D0-CC16-4C38-9582-01ED132BBED2@gmail.com> <201006150212.o5F2CTb08070@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox