pg.ddx.io pgsql-testers@postgresql.org mailing list archive
help / color / mirror / Atom feedConditional trigger missing from pg_dump
3+ messages / 2 participants
[nested] [flat]
* Conditional trigger missing from pg_dump
@ 2010-03-25 17:41 Josh Berkus <josh@agliodbs.com>
0 siblings, 1 reply; 3+ messages in thread
From: Josh Berkus @ 2010-03-25 17:41 UTC (permalink / raw)
To: pgsql-hackers@postgresql.org; +Cc: pgsql-testers
All,
It looks like pg_dump was never modified to include conditional
triggers. If you look in pg_dump.c, there's no provision to dump the
FOR UPDATE OF part of the trigger declaration.
This was discovered by Dave Olszewski while testing conditional triggers.
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Conditional trigger missing from pg_dump
@ 2010-03-25 17:45 Tom Lane <tgl@sss.pgh.pa.us>
parent: Josh Berkus <josh@agliodbs.com>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2010-03-25 17:45 UTC (permalink / raw)
To: Josh Berkus <josh@agliodbs.com>; +Cc: pgsql-hackers@postgresql.org; pgsql-testers
Josh Berkus <josh@agliodbs.com> writes:
> It looks like pg_dump was never modified to include conditional
> triggers. If you look in pg_dump.c, there's no provision to dump the
> FOR UPDATE OF part of the trigger declaration.
That proves nothing; it could be relying on server-side code to produce
the declaration.
> This was discovered by Dave Olszewski while testing conditional triggers.
Please show a specific example of what you're worried about.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Conditional trigger missing from pg_dump
@ 2010-03-25 18:13 Josh Berkus <josh@agliodbs.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 3+ messages in thread
From: Josh Berkus @ 2010-03-25 18:13 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers@postgresql.org
>> This was discovered by Dave Olszewski while testing conditional triggers.
>
> Please show a specific example of what you're worried about.
I'll get you a reproduceable test case later today. In our testing, the
conditional part of the trigger was not being dumped.
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2010-03-25 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-03-25 17:41 Conditional trigger missing from pg_dump Josh Berkus <josh@agliodbs.com>
2010-03-25 17:45 ` Tom Lane <tgl@sss.pgh.pa.us>
2010-03-25 18:13 ` Josh Berkus <josh@agliodbs.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox