public inbox for [email protected]
help / color / mirror / Atom feedv18 GUC in v17 translation
3+ messages / 2 participants
[nested] [flat]
* v18 GUC in v17 translation
@ 2025-11-14 14:12 Daniel Gustafsson <[email protected]>
2025-11-14 14:54 ` Re: v18 GUC in v17 translation Álvaro Herrera <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Gustafsson @ 2025-11-14 14:12 UTC (permalink / raw)
To: [email protected]
The Japanese initdb translation contains strings which are only present in v18
and onwards, which seems seems incorrect. While I know that we don't apply
changes directly to the in-tree .po files I attached a diff for that to
illustrate. Am I missing something or should these be removed from the source
translation repo?
--
Daniel Gustafsson
Attachments:
[application/octet-stream] jp_autovacuum_worker_slots.diff (650B, 2-jp_autovacuum_worker_slots.diff)
download | inline diff:
diff --git a/src/bin/initdb/po/ja.po b/src/bin/initdb/po/ja.po
index 8f6e6bf5c04..64b9d086f7d 100644
--- a/src/bin/initdb/po/ja.po
+++ b/src/bin/initdb/po/ja.po
@@ -397,11 +397,6 @@ msgstr "動的共有メモリの実装を選択しています ... "
msgid "selecting default \"max_connections\" ... "
msgstr "デフォルトの\"max_connections\"を選択しています ... "
-#: initdb.c:1190
-#, c-format
-msgid "selecting default \"autovacuum_worker_slots\" ... %d\n"
-msgstr "デフォルトの\"autovacuum_worker_slots\"を選択しています ... %d\n"
-
#: initdb.c:1193
#, c-format
msgid "selecting default \"shared_buffers\" ... "
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: v18 GUC in v17 translation
2025-11-14 14:12 v18 GUC in v17 translation Daniel Gustafsson <[email protected]>
@ 2025-11-14 14:54 ` Álvaro Herrera <[email protected]>
2025-11-14 14:59 ` Re: v18 GUC in v17 translation Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Álvaro Herrera @ 2025-11-14 14:54 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: [email protected]
On 2025-Nov-14, Daniel Gustafsson wrote:
> The Japanese initdb translation contains strings which are only present in v18
> and onwards, which seems seems incorrect. While I know that we don't apply
> changes directly to the in-tree .po files I attached a diff for that to
> illustrate. Am I missing something or should these be removed from the source
> translation repo?
Hmm, this is pretty harmless -- it just means the message catalog has an
entry that will never be used. But it won't have any bad consequences.
I don't think we need to go out of our ways to clean it up: the
automated merge workflow should eventually remove that string from the
source file.
It looks like this string came in with commit faf514a1ccf9 in the
pgtranslation/messages repository. I don't understand what could have
happened here, other than the translator downloading the file for the
wrong branch. Maybe this explains why the stats for Japanese in 17 are
much lower than for all other branches?
I think our branch handling is really confusing and could easily induce
people to do the wrong thing. I'm not sure what would be better,
though. I think we could just get rid of branch master altogether, and
create the next one from the previous (e.g., create REL_19_STABLE from
REL_18_STABLE), rather than branching the previous from master each
time.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Tiene valor aquel que admite que es un cobarde" (Fernandel)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: v18 GUC in v17 translation
2025-11-14 14:12 v18 GUC in v17 translation Daniel Gustafsson <[email protected]>
2025-11-14 14:54 ` Re: v18 GUC in v17 translation Álvaro Herrera <[email protected]>
@ 2025-11-14 14:59 ` Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Gustafsson @ 2025-11-14 14:59 UTC (permalink / raw)
To: Álvaro Herrera <[email protected]>; +Cc: [email protected]
> On 14 Nov 2025, at 15:54, Álvaro Herrera <[email protected]> wrote:
> Hmm, this is pretty harmless -- it just means the message catalog has an
> entry that will never be used. But it won't have any bad consequences.
Thanks for confirming!
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-11-14 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-11-14 14:12 v18 GUC in v17 translation Daniel Gustafsson <[email protected]>
2025-11-14 14:54 ` Álvaro Herrera <[email protected]>
2025-11-14 14:59 ` Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox