pg.ddx.io pgsql-translators@postgresql.org mailing list archive
help / color / mirror / Atom feedQuitting the thes
8+ messages / 5 participants
[nested] [flat]
* Quitting the thes
@ 2019-05-13 19:52 Stephen Amell <mrstephenamell@gmail.com>
2019-05-14 00:49 ` Re: Quitting the thes Michael Paquier <michael@paquier.xyz>
2019-06-12 18:40 ` Re: Quitting the thes Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 2 replies; 8+ messages in thread
From: Stephen Amell @ 2019-05-13 19:52 UTC (permalink / raw)
To: pgsql-hackers@postgresql.org
Hi all,
Here my first patch for postgres. Starting by an easy thing, I correct
the duplicated "the the" strings from comments on some files.
- src/backend/executor/execExpr.c
- src/include/c.h
- src/include/jit/llvmjit_emit.h
- src/include/nodes/execnodes.h
- src/include/replication/logical.h
Any feedback are welcome!
Thanks a lot,
diff --git a/src/backend/executor/execExpr.c b/src/backend/executor/execExpr.c
index 0fb31f5..0a7b2b8 100644
--- a/src/backend/executor/execExpr.c
+++ b/src/backend/executor/execExpr.c
@@ -2361,7 +2361,7 @@ get_last_attnums_walker(Node *node, LastAttnumInfo *info)
* Compute additional information for EEOP_*_FETCHSOME ops.
*
* The goal is to determine whether a slot is 'fixed', that is, every
- * evaluation of the the expression will have the same type of slot, with an
+ * evaluation of the expression will have the same type of slot, with an
* equivalent descriptor.
*/
static void
diff --git a/src/include/c.h b/src/include/c.h
index 33c9518..0f89c02 100644
--- a/src/include/c.h
+++ b/src/include/c.h
@@ -1129,7 +1129,7 @@ typedef union PGAlignedXLogBlock
* Please note IT IS NOT SAFE to cast constness away if the result will ever
* be modified (it would be undefined behaviour). Doing so anyway can cause
* compiler misoptimizations or runtime crashes (modifying readonly memory).
- * It is only safe to use when the the result will not be modified, but API
+ * It is only safe to use when the result will not be modified, but API
* design or language restrictions prevent you from declaring that
* (e.g. because a function returns both const and non-const variables).
*
diff --git a/src/include/jit/llvmjit_emit.h b/src/include/jit/llvmjit_emit.h
index 9569da6..71a8625 100644
--- a/src/include/jit/llvmjit_emit.h
+++ b/src/include/jit/llvmjit_emit.h
@@ -218,7 +218,7 @@ l_mcxt_switch(LLVMModuleRef mod, LLVMBuilderRef b, LLVMValueRef nc)
}
/*
- * Return pointer to the the argno'th argument nullness.
+ * Return pointer to the argno'th argument nullness.
*/
static inline LLVMValueRef
l_funcnullp(LLVMBuilderRef b, LLVMValueRef v_fcinfo, size_t argno)
@@ -236,7 +236,7 @@ l_funcnullp(LLVMBuilderRef b, LLVMValueRef v_fcinfo, size_t argno)
}
/*
- * Return pointer to the the argno'th argument datum.
+ * Return pointer to the argno'th argument datum.
*/
static inline LLVMValueRef
l_funcvaluep(LLVMBuilderRef b, LLVMValueRef v_fcinfo, size_t argno)
diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h
index ff33287..4b1635e 100644
--- a/src/include/nodes/execnodes.h
+++ b/src/include/nodes/execnodes.h
@@ -593,7 +593,7 @@ typedef struct EState
* and with which options. es_jit is created on-demand when JITing is
* performed.
*
- * es_jit_combined_instr is the the combined, on demand allocated,
+ * es_jit_combined_instr is the combined, on demand allocated,
* instrumentation from all workers. The leader's instrumentation is kept
* separate, and is combined on demand by ExplainPrintJITSummary().
*/
diff --git a/src/include/replication/logical.h b/src/include/replication/logical.h
index 0a2a63a..0daa38c 100644
--- a/src/include/replication/logical.h
+++ b/src/include/replication/logical.h
@@ -47,7 +47,7 @@ typedef struct LogicalDecodingContext
/*
* Marks the logical decoding context as fast forward decoding one. Such a
- * context does not have plugin loaded so most of the the following
+ * context does not have plugin loaded so most of the following
* properties are unused.
*/
bool fast_forward;
Attachments:
[text/plain] the-thes.patch (3.2K, ../../539fa271-21b3-777e-a468-d96cffe9c768@gmail.com/2-the-thes.patch)
download | inline diff:
diff --git a/src/backend/executor/execExpr.c b/src/backend/executor/execExpr.c
index 0fb31f5..0a7b2b8 100644
--- a/src/backend/executor/execExpr.c
+++ b/src/backend/executor/execExpr.c
@@ -2361,7 +2361,7 @@ get_last_attnums_walker(Node *node, LastAttnumInfo *info)
* Compute additional information for EEOP_*_FETCHSOME ops.
*
* The goal is to determine whether a slot is 'fixed', that is, every
- * evaluation of the the expression will have the same type of slot, with an
+ * evaluation of the expression will have the same type of slot, with an
* equivalent descriptor.
*/
static void
diff --git a/src/include/c.h b/src/include/c.h
index 33c9518..0f89c02 100644
--- a/src/include/c.h
+++ b/src/include/c.h
@@ -1129,7 +1129,7 @@ typedef union PGAlignedXLogBlock
* Please note IT IS NOT SAFE to cast constness away if the result will ever
* be modified (it would be undefined behaviour). Doing so anyway can cause
* compiler misoptimizations or runtime crashes (modifying readonly memory).
- * It is only safe to use when the the result will not be modified, but API
+ * It is only safe to use when the result will not be modified, but API
* design or language restrictions prevent you from declaring that
* (e.g. because a function returns both const and non-const variables).
*
diff --git a/src/include/jit/llvmjit_emit.h b/src/include/jit/llvmjit_emit.h
index 9569da6..71a8625 100644
--- a/src/include/jit/llvmjit_emit.h
+++ b/src/include/jit/llvmjit_emit.h
@@ -218,7 +218,7 @@ l_mcxt_switch(LLVMModuleRef mod, LLVMBuilderRef b, LLVMValueRef nc)
}
/*
- * Return pointer to the the argno'th argument nullness.
+ * Return pointer to the argno'th argument nullness.
*/
static inline LLVMValueRef
l_funcnullp(LLVMBuilderRef b, LLVMValueRef v_fcinfo, size_t argno)
@@ -236,7 +236,7 @@ l_funcnullp(LLVMBuilderRef b, LLVMValueRef v_fcinfo, size_t argno)
}
/*
- * Return pointer to the the argno'th argument datum.
+ * Return pointer to the argno'th argument datum.
*/
static inline LLVMValueRef
l_funcvaluep(LLVMBuilderRef b, LLVMValueRef v_fcinfo, size_t argno)
diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h
index ff33287..4b1635e 100644
--- a/src/include/nodes/execnodes.h
+++ b/src/include/nodes/execnodes.h
@@ -593,7 +593,7 @@ typedef struct EState
* and with which options. es_jit is created on-demand when JITing is
* performed.
*
- * es_jit_combined_instr is the the combined, on demand allocated,
+ * es_jit_combined_instr is the combined, on demand allocated,
* instrumentation from all workers. The leader's instrumentation is kept
* separate, and is combined on demand by ExplainPrintJITSummary().
*/
diff --git a/src/include/replication/logical.h b/src/include/replication/logical.h
index 0a2a63a..0daa38c 100644
--- a/src/include/replication/logical.h
+++ b/src/include/replication/logical.h
@@ -47,7 +47,7 @@ typedef struct LogicalDecodingContext
/*
* Marks the logical decoding context as fast forward decoding one. Such a
- * context does not have plugin loaded so most of the the following
+ * context does not have plugin loaded so most of the following
* properties are unused.
*/
bool fast_forward;
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Quitting the thes
2019-05-13 19:52 Quitting the thes Stephen Amell <mrstephenamell@gmail.com>
@ 2019-05-14 00:49 ` Michael Paquier <michael@paquier.xyz>
2019-06-12 18:45 ` Re: Quitting the thes Alvaro Herrera <alvherre@2ndquadrant.com>
1 sibling, 1 reply; 8+ messages in thread
From: Michael Paquier @ 2019-05-14 00:49 UTC (permalink / raw)
To: Stephen Amell <mrstephenamell@gmail.com>; +Cc: pgsql-hackers@postgresql.org
On Mon, May 13, 2019 at 04:52:15PM -0300, Stephen Amell wrote:
> Here my first patch for postgres. Starting by an easy thing, I correct the
> duplicated "the the" strings from comments on some files.
Welcome!
> - src/backend/executor/execExpr.c
> - src/include/c.h
> - src/include/jit/llvmjit_emit.h
> - src/include/nodes/execnodes.h
> - src/include/replication/logical.h
>
> Any feedback are welcome!
Thanks, committed. I have noticed an extra one in reorderbuffer.c.
If you get interested in more areas of the code, there is plently of
small work items which can be reviewed or worked on.
We have on the wiki a manual about how to submit a patch:
https://wiki.postgresql.org/wiki/Submitting_a_Patch
Patches go through a dedicated commit fest app, and it has many small
fishes which can be worked on:
https://commitfest.postgresql.org/23/
You could get more familiar with some areas of the code this way.
Thanks,
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../20190514004911.GC1418@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Quitting the thes
2019-05-13 19:52 Quitting the thes Stephen Amell <mrstephenamell@gmail.com>
2019-05-14 00:49 ` Re: Quitting the thes Michael Paquier <michael@paquier.xyz>
@ 2019-06-12 18:45 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-06-12 19:42 ` Re: Quitting the thes Guillaume Lelarge <guillaume@lelarge.info>
2019-06-13 06:44 ` Re: Quitting the thes Michael Paquier <michael@paquier.xyz>
0 siblings, 2 replies; 8+ messages in thread
From: Alvaro Herrera @ 2019-06-12 18:45 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Stephen Amell <mrstephenamell@gmail.com>; pgsql-hackers@postgresql.org
On 2019-May-14, Michael Paquier wrote:
> Thanks, committed. I have noticed an extra one in reorderbuffer.c.
Some grepping found a bit more; patch attached.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
[text/x-diff] 0001-Fix-double-word-typos.patch (0B, ../../20190612184527.GA24266@alvherre.pgsql/2-0001-Fix-double-word-typos.patch)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Quitting the thes
2019-05-13 19:52 Quitting the thes Stephen Amell <mrstephenamell@gmail.com>
2019-05-14 00:49 ` Re: Quitting the thes Michael Paquier <michael@paquier.xyz>
2019-06-12 18:45 ` Re: Quitting the thes Alvaro Herrera <alvherre@2ndquadrant.com>
@ 2019-06-12 19:42 ` Guillaume Lelarge <guillaume@lelarge.info>
1 sibling, 0 replies; 8+ messages in thread
From: Guillaume Lelarge @ 2019-06-12 19:42 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: Michael Paquier <michael@paquier.xyz>; Stephen Amell <mrstephenamell@gmail.com>; PostgreSQL Developers <pgsql-hackers@postgresql.org>
Le mer. 12 juin 2019 à 20:45, Alvaro Herrera <alvherre@2ndquadrant.com> a
écrit :
> On 2019-May-14, Michael Paquier wrote:
>
> > Thanks, committed. I have noticed an extra one in reorderbuffer.c.
>
> Some grepping found a bit more; patch attached.
>
>
Thanks a lot, this is very good. I've got some fixes to do :)
--
Guillaume.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Quitting the thes
2019-05-13 19:52 Quitting the thes Stephen Amell <mrstephenamell@gmail.com>
2019-05-14 00:49 ` Re: Quitting the thes Michael Paquier <michael@paquier.xyz>
2019-06-12 18:45 ` Re: Quitting the thes Alvaro Herrera <alvherre@2ndquadrant.com>
@ 2019-06-13 06:44 ` Michael Paquier <michael@paquier.xyz>
2019-06-13 14:10 ` Re: Quitting the thes Alvaro Herrera <alvherre@2ndquadrant.com>
1 sibling, 1 reply; 8+ messages in thread
From: Michael Paquier @ 2019-06-13 06:44 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: Stephen Amell <mrstephenamell@gmail.com>; pgsql-hackers@postgresql.org
On Wed, Jun 12, 2019 at 02:45:27PM -0400, Alvaro Herrera wrote:
> Some grepping found a bit more; patch attached.
Indeed. There were much more. I just got to look with stuff like
that:
find . -name "*.c" | xargs egrep "(\b[a-zA-Z]+) \1\b"
But I did not find any more spots. Indentation is incorrect in
test_integerset.c.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../20190613064443.GF1643@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Quitting the thes
2019-05-13 19:52 Quitting the thes Stephen Amell <mrstephenamell@gmail.com>
2019-05-14 00:49 ` Re: Quitting the thes Michael Paquier <michael@paquier.xyz>
2019-06-12 18:45 ` Re: Quitting the thes Alvaro Herrera <alvherre@2ndquadrant.com>
2019-06-13 06:44 ` Re: Quitting the thes Michael Paquier <michael@paquier.xyz>
@ 2019-06-13 14:10 ` Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 0 replies; 8+ messages in thread
From: Alvaro Herrera @ 2019-06-13 14:10 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Stephen Amell <mrstephenamell@gmail.com>; pgsql-hackers@postgresql.org
On 2019-Jun-13, Michael Paquier wrote:
> On Wed, Jun 12, 2019 at 02:45:27PM -0400, Alvaro Herrera wrote:
> > Some grepping found a bit more; patch attached.
>
> Indeed. There were much more. I just got to look with stuff like
> that:
> find . -name "*.c" | xargs egrep "(\b[a-zA-Z]+) \1\b"
This is what I used:
git grep '\<\([a-z_ ]\+\)\> \<\1\>'
> But I did not find any more spots. Indentation is incorrect in
> test_integerset.c.
Indeed ... fixed.
Thanks for looking,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Quitting the thes
2019-05-13 19:52 Quitting the thes Stephen Amell <mrstephenamell@gmail.com>
@ 2019-06-12 18:40 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-06-16 20:51 ` Re: Quitting the thes Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
1 sibling, 1 reply; 8+ messages in thread
From: Alvaro Herrera @ 2019-06-12 18:40 UTC (permalink / raw)
To: pgsql-translators; +Cc: Begina Felicysym <begina.felicysym@wp.eu>; Daniele Varrazzo <daniele.varrazzo@gmail.com>; Dennis Björklund <db@zigo.dhs.org>; Devrim GÜNDÜZ <devrim@gunduz.org>; Guillaume Lelarge <guillaume@lelarge.info>; Julien Rouhaud <rjuju123@gmail.com>; Peter Eisentraut <peter@eisentraut.org>; Tomas Vondra <tv@fuzzy.cz>
Hi all
(CC'ing 'Last-Translator' addresses)
I noticed a few duplicated words in the .po files. Some of these are
obviously false positives.
This command reports them with color highlighting:
$ git grep '\<\([a-z_ ]\+\)\> \<\1\>' -- *.po
src/backend/po/de.po:msgstr "Wenn der Planer schätzt, dass zu wenige Tabellenseiten gelesen werden werden um diesen Wert zu erreichen, dann wird kein paralleler Scan in Erwägung gezogen werden."
src/backend/po/de.po:msgstr "Wenn der Planer schätzt, dass zu wenige Indexseiten gelesen werden werden um diesen Wert zu erreichen, dann wird kein paralleler Scan in Erwägung gezogen werden."
src/backend/po/de.po:msgstr "Setzt den vom Planer geschätzten Anteil der Cursor-Zeilen, die ausgelesen werden werden."
src/backend/po/fr.po:msgstr "l'extension « %s » n'a pas de script d'installation ou de chemin de de mise à jour pour la version « %s »"
src/backend/po/fr.po:msgstr "les fonctions in_range btree doivent doivent retourner un booléen"
src/backend/po/fr.po:msgstr "la relation référencée « %s » n'est ni une table ni une table distante"
src/backend/po/fr.po:msgstr "la relation héritée « %s » n'est ni une table ni une table distante"
src/backend/po/fr.po:"l'option DISABLE_PAGE_SKIPPING de la commande VACUUM ne pas pas être utilisée\n"
src/backend/po/fr.po:"Vous pourriez avoir avoir besoin d'ajouter des conversions de type explicites."
src/backend/po/fr.po:msgstr "symbole « %c » invalide invalide lors du décodage de la séquence en base64"
src/backend/po/fr.po:msgstr "La chaîne des des guillements doubles non fermés."
src/backend/po/id.po:msgstr "sambungan terputus saat COPY ke stdout stdout"
src/backend/po/id.po:msgstr "Gunakan 'quoted CSV field' untuk menyatakan baris baris baru"
src/backend/po/id.po:msgstr "file konfigurasi « %s » terdapat errors ; tidak tidak terpengaruh applied"
src/backend/po/it.po:msgstr "le protezioni di wraparound dei membri MultiXact sono disabilitate perché il il MultiXact più vecchio che abbia ricevuto un checkpoint %u non esiste sul disco"
src/backend/po/it.po:msgstr "La rilevazione di un errore in una somma di controllo di solito fa generare a PostgreSQL un errore che fa abortire la transazione corrente. Impostare ignore_checksum_failure a \"true\" fa sì che il sistema ignori l'errore (che viene riportato come un avviso), consentendo al processo di continuare. Questo comportamento potrebbe causare crash o altri problemi gravi. Ha effetto solo se se somme di controllo sono abilitate."
src/backend/po/sv.po:msgid "tid (%u, %u) is not valid for relation for relation \"%s\""
src/backend/po/tr.po:msgstr "\"%2$s\" kullanarak kullanarak PID %1$d olan başka bir istemci süreci çalışmakta mıdır?"
src/backend/po/tr.po:msgstr "\"%2$s\" kullanarak kullanarak PID %1$d olan başka bir sunucu çalışmakta mıdır?"
src/bin/initdb/po/cs.po:msgstr "Spusťte znovu %s s přepínačem -E.\n"
src/bin/initdb/po/cs.po:"Pusťte znovu %s s jiným nastavením locale.\n"
src/bin/initdb/po/tr.po:"kaldırın, ya boşaltın ya da ya da %s 'i \n"
src/bin/pg_basebackup/po/de.po:"Optionen, die die Ausgabe kontrollieren:\n"
src/bin/pg_basebackup/po/tr.po:msgstr "%s: --no-slot slot adıyla birlikte kullanılamaz\n"
src/bin/pg_dump/po/de.po:"Optionen die die Wiederherstellung kontrollieren:\n"
src/bin/pg_resetwal/po/it.po:msgstr " (zero in uno dei dei valori vuol dire nessun cambiamento)\n"
src/bin/psql/po/de.po:msgstr "ändert den Eigentümer der der Rolle gehörenden Datenbankobjekte"
src/bin/scripts/po/pl.po:msgstr " -t, --timeout=SEKUNDY sekundy oczekiwania podczas podczas próby połączenia, 0 wyłącza (domyślnie: %s)\n"
src/interfaces/ecpg/ecpglib/po/pl.po:msgstr "zmienna nie ma typu typu numeric, linia %d"
src/interfaces/ecpg/ecpglib/po/pl.po:msgstr "zmienna nie ma typu typu character, linia %d"
src/interfaces/libpq/po/fr.po:msgstr "mot de passe récupéré dans le fichier fichier « %s »\n"
src/interfaces/libpq/po/it.po:msgstr "non è stato possibile possibile ottenere il certificato: %s\n"
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Quitting the thes
2019-05-13 19:52 Quitting the thes Stephen Amell <mrstephenamell@gmail.com>
2019-06-12 18:40 ` Re: Quitting the thes Alvaro Herrera <alvherre@2ndquadrant.com>
@ 2019-06-16 20:51 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 0 replies; 8+ messages in thread
From: Peter Eisentraut @ 2019-06-16 20:51 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-translators; +Cc: Begina Felicysym <begina.felicysym@wp.eu>; Daniele Varrazzo <daniele.varrazzo@gmail.com>; Dennis Björklund <db@zigo.dhs.org>; Devrim GÜNDÜZ <devrim@gunduz.org>; Guillaume Lelarge <guillaume@lelarge.info>; Julien Rouhaud <rjuju123@gmail.com>; Tomas Vondra <tv@fuzzy.cz>
On 2019-06-12 20:40, Alvaro Herrera wrote:
> I noticed a few duplicated words in the .po files. Some of these are
> obviously false positives.
The "de" ones were all correct as is, but some of the ones in other
languages do indeed look like typos.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2019-06-16 20:51 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 19:52 Quitting the thes Stephen Amell <mrstephenamell@gmail.com>
2019-05-14 00:49 ` Michael Paquier <michael@paquier.xyz>
2019-06-12 18:45 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-06-12 19:42 ` Guillaume Lelarge <guillaume@lelarge.info>
2019-06-13 06:44 ` Michael Paquier <michael@paquier.xyz>
2019-06-13 14:10 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-06-12 18:40 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-06-16 20:51 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox