public inbox for [email protected]
help / color / mirror / Atom feed[PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments
3+ messages / 2 participants
[nested] [flat]
* [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments
@ 2026-02-20 10:12 VASUKI M <[email protected]>
2026-02-25 16:12 ` Re: [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments Álvaro Herrera <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: VASUKI M @ 2026-02-20 10:12 UTC (permalink / raw)
To: [email protected]; +Cc: Daniel Gustafsson <[email protected]>
Hi all,
While reviewing the Spanish translation file (src/backend/po/es.po),
I found an incorrect translation in the message:
"physical replication slot \"%s\" exists, but \"wal_level\" < \"replica\""
The current translation refers to a logical replication slot
("replicación lógica"), which is incorrect in this context.
This patch corrects the translation to use "replicación física",
so that the message accurately reflects the original meaning.
In addition, I reviewed several FIXME comments present in the same
file, including comments referencing slot.c:779 and postmaster.c:835,
as well as notes questioning duplication and terminology (e.g.,
"snapbuild" and "snapshot"). After verifying the corresponding
source code and checking for message duplication, these comments
appear to be outdated translator notes that no longer apply to the
current codebase.
This patch removes those obsolete FIXME comments while keeping
the existing translations unchanged, except for the corrected
physical replication slot message described above.
The updated es.po file was validated using:
msgfmt -c -v es.po
which reports no format or consistency issues.
Patch attached.
Regards,
Vasuki M
C-DAC,Chennai
Attachments:
[text/x-patch] v1-0001-Fix-incorrect-spanish-translation-and-remove-FIXME.patch (6.4K, 3-v1-0001-Fix-incorrect-spanish-translation-and-remove-FIXME.patch)
download | inline diff:
From b96467e4e70993ff036aafbdf3379cbc2d2d5b94 Mon Sep 17 00:00:00 2001
From: Vasuki M <[email protected]>
Date: Fri, 20 Feb 2026 15:07:10 +0530
Subject: [PATCH] Fix incorrect Spanish translation for physical replication
slot message and remove obsolete FIXME comments
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The message
"physical replication slot \"%s\" exists, but \"wal_level\" < \"replica\""
was incorrectly translated as referring to a logical replication slot.
This patch corrects the translation to use "replicación física".
Additionally, several obsolete FIXME comments in
src/backend/po/es.po were removed after verifying that they
no longer correspond to the current source code.
---
src/backend/po/es.po | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/src/backend/po/es.po b/src/backend/po/es.po
index e2593b52..4be2aa2d 100644
--- a/src/backend/po/es.po
+++ b/src/backend/po/es.po
@@ -20239,7 +20239,6 @@ msgstr "no se pudo enviar datos a la cola en memoria compartida"
msgid "logical replication apply worker will serialize the remaining changes of remote transaction %u to a file"
msgstr "el ayudante paralelo «apply» de replicación lógica serializará los cambios restantes de la transacción remota %u a un archivo"
-# FIXME see slot.c:779. See also postmaster.c:835
#: replication/logical/decode.c:177 replication/logical/logical.c:141
#, c-format
msgid "logical decoding on standby requires \"wal_level\" >= \"logical\" on the primary"
@@ -20279,7 +20278,6 @@ msgstr "el slot del worker de replicación lógica %d está vacío, no se puede
msgid "logical replication worker slot %d is already used by another worker, cannot attach"
msgstr "el slot de replicación lógica %d ya está siendo utilizado por otro worker, no se puede adjuntar"
-# FIXME see slot.c:779. See also postmaster.c:835
#: replication/logical/logical.c:121
#, c-format
msgid "logical decoding requires \"wal_level\" >= \"logical\""
@@ -20351,7 +20349,6 @@ msgstr "Transacciones en flujo comprometiendo después de %X/%X, leyendo WAL des
msgid "slot \"%s\", output plugin \"%s\", in the %s callback, associated LSN %X/%X"
msgstr "slot «%s», plugin de salida «%s», en el callback %s, LSN asociado %X/%X"
-# FIXME must quote callback name? Need a translator: comment?
#: replication/logical/logical.c:784
#, c-format
msgid "slot \"%s\", output plugin \"%s\", in the %s callback"
@@ -20542,7 +20539,6 @@ msgstr "no se pudo leer desde el archivo de desborde de reorderbuffer: se leyero
msgid "could not remove file \"%s\" during removal of pg_replslot/%s/xid*: %m"
msgstr "no se pudo borrar el archivo «%s» durante la eliminación de pg_replslot/%s/xid*: %m"
-# FIXME almost duplicated again!?
#: replication/logical/reorderbuffer.c:5120
#, c-format
msgid "could not read from file \"%s\": read %d instead of %d bytes"
@@ -20622,7 +20618,6 @@ msgstr "el slot de replicación «%s» especificado por «%s» no existe en el s
msgid "replication slot synchronization requires \"%s\" to be specified in \"%s\""
msgstr "la sincronización de slots de replicación requiere que «%s» esté especificado en «%s»"
-# FIXME see slot.c:779. See also postmaster.c:835
#: replication/logical/slotsync.c:1050
#, c-format
msgid "replication slot synchronization requires \"wal_level\" >= \"logical\""
@@ -20682,7 +20677,6 @@ msgstr "no se pudo conectar al servidor primario: %s"
msgid "initial slot snapshot too large"
msgstr "el snapshot inicial del slot es demasiado grande"
-# FIXME: snapshot? instantánea?
#: replication/logical/snapbuild.c:707
#, c-format
msgid "exported logical decoding snapshot: \"%s\" with %u transaction ID"
@@ -20721,7 +20715,6 @@ msgstr "la decodificación lógica encontró un punto consistente inicial en %X/
msgid "There are no old transactions anymore."
msgstr "Ya no hay transacciones antiguas en ejecución."
-# FIXME "snapbuild"?
#: replication/logical/snapbuild.c:1904
#, c-format
msgid "snapbuild state file \"%s\" has wrong magic number: %u instead of %u"
@@ -21118,7 +21111,6 @@ msgstr "no se pudo eliminar el directorio «%s»"
msgid "replication slots can only be used if \"max_replication_slots\" > 0"
msgstr "los slots de replicación sólo pueden usarse si «max_replication_slots» > 0"
-# FIXME see logical.c:81
#: replication/slot.c:1377
#, c-format
msgid "replication slots can only be used if \"wal_level\" >= \"replica\""
@@ -21146,7 +21138,6 @@ msgstr[1] "El restart_lsn %X/%X del slot excede el límite por %llu bytes."
msgid "The slot conflicted with xid horizon %u."
msgstr "El slot estaba en conflicto con el horizonte de XID %u."
-# FIXME see slot.c:779. See also postmaster.c:835
#: replication/slot.c:1511
msgid "Logical decoding on standby requires \"wal_level\" >= \"logical\" on the primary server."
msgstr "La decodificación lógica en standby requiere «wal_level» >= «logical» en el primario."
@@ -21181,7 +21172,6 @@ msgstr "el archivo de slot de replicación «%s» tiene largo corrupto %u"
msgid "checksum mismatch for replication slot file \"%s\": is %u, should be %u"
msgstr "suma de verificación no coincidente en archivo de slot de replicación «%s»: es %u, debería ser %u"
-# FIXME see slot.c:779. See also postmaster.c:835
#: replication/slot.c:2333
#, c-format
msgid "logical replication slot \"%s\" exists, but \"wal_level\" < \"logical\""
@@ -21192,11 +21182,10 @@ msgstr "existe el slot de replicación lógica «%s», pero «wal_level» < «lo
msgid "Change \"wal_level\" to be \"logical\" or higher."
msgstr "Cambie «wal_level» a «logical» o superior."
-# FIXME see slot.c:779. See also postmaster.c:835
#: replication/slot.c:2339
#, c-format
msgid "physical replication slot \"%s\" exists, but \"wal_level\" < \"replica\""
-msgstr "existe el slot de replicación lógica «%s», pero «wal_level» < «replica»"
+msgstr "existe el slot de replicación física «%s», pero «wal_level» < «replica»"
# <> hello vim
#: replication/slot.c:2341
@@ -21319,7 +21308,6 @@ msgstr "no se puede copiar el slot de replicación lógica no terminado «%s»"
msgid "Retry when the source replication slot's confirmed_flush_lsn is valid."
msgstr "Reintente cuando el confirmed_flush_lsn del slot de replicación de origen sea válido."
-# FIXME see logical.c:81
#: replication/slotfuncs.c:877
#, c-format
msgid "replication slots can only be synchronized to a standby server"
--
2.43.0
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments
2026-02-20 10:12 [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments VASUKI M <[email protected]>
@ 2026-02-25 16:12 ` Álvaro Herrera <[email protected]>
2026-02-26 06:30 ` Re: [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments VASUKI M <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Álvaro Herrera @ 2026-02-25 16:12 UTC (permalink / raw)
To: VASUKI M <[email protected]>; +Cc: [email protected]; Daniel Gustafsson <[email protected]>
Hello,
Many thanks for the report!
On 2026-Feb-20, VASUKI M wrote:
> While reviewing the Spanish translation file (src/backend/po/es.po),
> I found an incorrect translation in the message:
>
> "physical replication slot \"%s\" exists, but \"wal_level\" < \"replica\""
>
> The current translation refers to a logical replication slot
> ("replicación lógica"), which is incorrect in this context.
> This patch corrects the translation to use "replicación física",
> so that the message accurately reflects the original meaning.
Your patch applies only to branch 17, but the translation is actually
incorrect in all branches. (More precisely, the message fix applies;
the FIXME removals were all reported as merge failures). Moreover, in
branches 14 through 16, the translation said "replica" instead of
"logical", which is what the original has. So I fixed that as well.
(Another point is that in this repository the file is actually named
es/postgres.po, so what I actually did was "patch es/postgres.po <
/tmp/yourpatch" rather than any git commands.)
I used this command to search for other potentially affected
translations,
msggrep --no-wrap -K -e 'replication slot.*exists.*but' es/postgres.po
which found none.
I didn't commit the FIXME removals, because it'd be a pain to merge
them, and also even if they no longer reference a relevant code
location, they are pointing out an issue that continues to exist --
namely, that the original messages shouldn't have the string "logical"
or "replica" as the value being compared to wal_level, but instead they
should do something lik this:
ereport(FATAL,
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
errmsg("logical replication slot \"%s\" exists, but \"%s\" < \"%s\"",
NameStr(cp.slotdata.name), "wal_level", "replica"),
errhint("Change \"%s\" to be \"%s\" or higher.",
"wal_level", "replica")));
However, I never got around to fixing the code on the grounds there were
only two affected messages; I think this ultimately proved a judgement
mistake, because when the required level was changed from logical to
replica, we all had to update the translations.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Ed is the standard text editor."
http://groups.google.com/group/alt.religion.emacs/msg/8d94ddab6a9b0ad3
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments
2026-02-20 10:12 [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments VASUKI M <[email protected]>
2026-02-25 16:12 ` Re: [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments Álvaro Herrera <[email protected]>
@ 2026-02-26 06:30 ` VASUKI M <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: VASUKI M @ 2026-02-26 06:30 UTC (permalink / raw)
To: Álvaro Herrera <[email protected]>; +Cc: [email protected]; Daniel Gustafsson <[email protected]>
Hi Álvaro,
Thank you very much for reviewing the patch and applying the
translation fix across the affected branches.
I appreciate the clarification regarding the FIXME comments and
the underlying message structure. That makes sense, and I understand
why keeping them is useful until the message formatting is improved
in the source code.
Thanks again for the guidance.
Regards,
Vasuki M
CDAC,Chennai
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-02-26 06:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-20 10:12 [PATCH] Fix incorrect Spanish translation and remove obsolete FIXME comments VASUKI M <[email protected]>
2026-02-25 16:12 ` Álvaro Herrera <[email protected]>
2026-02-26 06:30 ` VASUKI M <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox