public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Smith <[email protected]>
To: [email protected]
Subject: Fwd: Some deleted GUCs are still referred to
Date: Wed, 15 Nov 2023 12:20:10 +1100
Message-ID: <CAHut+Pv_2QtyS9DwKoLVp7PgL7S02JqyQWmXxXTRjwaeSYQiKg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAHut+PtkMHzMk3+kDYSNzf8+=K30zuC3EzLRZxnAt58DhWQeRQ@mail.gmail.com>
<[email protected]>
FYI.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
---------- Forwarded message ---------
From: Daniel Gustafsson <[email protected]>
Date: Thu, Nov 9, 2023 at 8:12 PM
Subject: Re: Some deleted GUCs are still referred to
To: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
> On 9 Nov 2023, at 00:51, Peter Smith <[email protected]> wrote:
>
> Hi,
>
> I happened to notice that some GUC names "max_fsm_pages" and
> "max_fsm_relations" are still mentioned in these translation files
> (from the REL_16_1 source zip)
>
> src\backend\po\fr.po
> src\backend\po\tr.po
>
> ~~
>
> Should those be removed?
These mentions are only in comments and not in actual translations, so I don't
think they risk causing any issues.
$ git grep max_fsm_ |cut -d":" -f 2 |grep -v "^#" | wc -l
0
I don't know enough about the translation workflow to know how these comments
are handled, sending this to pgsql-translators@ might be a better way to reach
the authors working on this.
> There was a commit [1] that said these all traces of those GUCs had
> been eliminated.
Translations are managed in an external repo and synced with the main repo at
intervals, so such a commit couldn't have updated the master translation work
files anyways.
--
Daniel Gustafsson
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: Fwd: Some deleted GUCs are still referred to
In-Reply-To: <CAHut+Pv_2QtyS9DwKoLVp7PgL7S02JqyQWmXxXTRjwaeSYQiKg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox