public inbox for [email protected]  

help / color / mirror / Atom feed

CF app: "target version" entered twice?
3+ messages / 3 participants
[nested] [flat]

* CF app: "target version" entered twice?
@ 2019-02-27 23:26  Alvaro Herrera <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Alvaro Herrera @ 2019-02-27 23:26 UTC (permalink / raw)
  To: w^3 <[email protected]>; +Cc: Magnus Hagander <[email protected]>

I just created a new patch in the commitfest app
(https://commitfest.postgresql.org/22/new/).  The app asked me on the
first page for the target version ... and then again on the second page.
And it didn't remember what I selected first.

I suppose the fix is just to remove the "target version" selectable on
the first page?

-- 
Álvaro Herrera                                http://www.twitter.com/alvherre
Al principio era UNIX, y UNIX habló y dijo: "Hello world\n".
No dijo "Hello New Jersey\n", ni "Hello USA\n".




^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: CF app: "target version" entered twice?
@ 2019-02-27 23:45  Tom Lane <[email protected]>
  parent: Alvaro Herrera <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Tom Lane @ 2019-02-27 23:45 UTC (permalink / raw)
  To: Alvaro Herrera <[email protected]>; +Cc: w^3 <[email protected]>; Magnus Hagander <[email protected]>

Alvaro Herrera <[email protected]> writes:
> I just created a new patch in the commitfest app
> (https://commitfest.postgresql.org/22/new/).  The app asked me on the
> first page for the target version ... and then again on the second page.
> And it didn't remember what I selected first.

Yeah, I noticed the same a couple days ago.

> I suppose the fix is just to remove the "target version" selectable on
> the first page?

Seems like the path of least resistance.  I'm not sure this is so
important it has to be on the first page, anyway.

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: CF app: "target version" entered twice?
@ 2019-02-28 11:24  Magnus Hagander <[email protected]>
  parent: Tom Lane <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Magnus Hagander @ 2019-02-28 11:24 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; w^3 <[email protected]>

On Thu, Feb 28, 2019 at 12:45 AM Tom Lane <[email protected]> wrote:

> Alvaro Herrera <[email protected]> writes:
> > I just created a new patch in the commitfest app
> > (https://commitfest.postgresql.org/22/new/).  The app asked me on the
> > first page for the target version ... and then again on the second page.
> > And it didn't remember what I selected first.
>
> Yeah, I noticed the same a couple days ago.
>
> > I suppose the fix is just to remove the "target version" selectable on
> > the first page?
>
> Seems like the path of least resistance.  I'm not sure this is so
> important it has to be on the first page, anyway.
>

That wasn't even intentional :) The form had a list of "include all fields
except x,y,z" so when the field was added it was automatically added there,
and I missed it. I've now switched it to instead list the *included* fields
so this won't happen again -- and it's easier to list 2 included fields
than 12 excluded ones.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

end of thread, other threads:[~2019-02-28 11:24 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-02-27 23:26 CF app: "target version" entered twice? Alvaro Herrera <[email protected]>
2019-02-27 23:45 ` Tom Lane <[email protected]>
2019-02-28 11:24   ` Magnus Hagander <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox