From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-www@lists.postgresql.org
Subject: Re: Bogus reports from coverage.postgresql.org
Date: Fri, 09 Mar 2018 23:42:33 -0500
Message-ID: <15758.1520656953@sss.pgh.pa.us> (raw)
In-Reply-To: <20180310040627.nwckurme2w42onp3@alap3.anarazel.de>
References: <30022.1520642188@sss.pgh.pa.us>
<20180310040627.nwckurme2w42onp3@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2018-03-09 19:36:28 -0500, Tom Lane wrote:
>> I happened to notice that if you look at
>> https://coverage.postgresql.org/src/backend/optimizer/util/predtest.c.gcov.html
>> it claims that the two occurrences of
>> elog(ERROR, "predicate_classify returned a bogus value");
>> at lines 492 and 803 are reached.
> Is it possible that the compiler figured that the patch is unreachable
> and removed the code?
Maybe, but then it's even less reasonable to claim that the lines
were reached.
In general, lcov seems to ignore lines for which no code was generated,
which is fine by me.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-www@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-www@lists.postgresql.org
Subject: Re: Bogus reports from coverage.postgresql.org
In-Reply-To: <15758.1520656953@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox