From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Đặng Minh Hướng <kakalot49@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Postgres 11 release notes
Date: Tue, 15 May 2018 10:01:27 -0400
Message-ID: <18049.1526392887@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKJS1f-XnmWDfuAibBGObmCGRoHo7tbuMebzAMUtxfJg+bUOcg@mail.gmail.com>
References: <20180511150852.GA18510@momjian.us>
<CANHVJ5cOKO6M9iTio0sG_pyrPnifUiGrcXC_gjmVtirX2Wpu+w@mail.gmail.com>
<20180514202850.GE5217@momjian.us>
<CAKJS1f-XnmWDfuAibBGObmCGRoHo7tbuMebzAMUtxfJg+bUOcg@mail.gmail.com>
David Rowley <david.rowley@2ndquadrant.com> writes:
> On 15 May 2018 at 08:28, Bruce Momjian <bruce@momjian.us> wrote:
>> Consistently return <literal>NaN</literal> for
>> <literal>NaN</literal> inputs to <function>power()</literal>
>> on older platforms (Dang Minh Huong)
> While I'm not in favour of removing Dang's credit here, technically
> this patch was Tom's. The code added in float.c by Dang's patch
> (61b200e2f) was effectively reverted by 6bdf1303. Dang's regression
> tests remain, so should also be credited along with Tom.
I'm not particularly fussed about getting credit for that. However,
looking again at how that patch series turned out --- ie, that
we ensured POSIX behavior for NaNs only in HEAD --- I wonder
whether we shouldn't do what was mentioned in the commit log for
6bdf1303, and teach numeric_pow() about these same special cases.
It seems like it would be more consistent to change both functions
for v11, rather than letting that other shoe drop in some future
major release.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-www@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.rowley@2ndquadrant.com, bruce@momjian.us, kakalot49@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Postgres 11 release notes
In-Reply-To: <18049.1526392887@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox