public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nils <[email protected]>
To: [email protected]
Subject: [PATCH] Improve portability of pgweb/load_initial_data.sh
Date: Sun, 7 Nov 2021 16:49:51 +0000
Message-ID: <20211107164951.wxcyp7iar2s4mjkn@nixos> (raw)

The shell script doesn't use bash extensions and bash may not be
available on all systems at that location.

If CDPATH is set, in certain cases, the call to cd can result in
unwanted behaviour.
---
 pgweb/load_initial_data.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pgweb/load_initial_data.sh b/pgweb/load_initial_data.sh
index fb16e70c..c419f298 100755
--- a/pgweb/load_initial_data.sh
+++ b/pgweb/load_initial_data.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 # We keep this in a separate script because using initial_data.xxx in django will overwrite
 # critical data in the database when running a 'syncdb'. We'd like to keep the ability to
@@ -8,7 +8,7 @@ echo WARNING: this may overwrite some data in the database with an initial set o
 echo 'Are you sure you want this (answer "yes" to overwrite)'
 read R
 
-cd $(dirname $0)
+CDPATH= cd $(dirname $0)
 
 if [ "$R" == "yes" ]; then
    find . -name data.json | xargs ../manage.py loaddata
-- 
2.31.1

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCH] Improve portability of pgweb/load_initial_data.sh
  In-Reply-To: <20211107164951.wxcyp7iar2s4mjkn@nixos>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox