public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Nils Andre <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Improve portability of pgweb/load_initial_data.sh
Date: Wed, 24 Nov 2021 14:56:03 +0100
Message-ID: <CABUevEyR-jfGWquPTCNpBiw+O_tmHT1xi+9HbYJuXFqjwzu_dQ@mail.gmail.com> (raw)
In-Reply-To: <20211109225734.7evav44x7nf5c5jb@nixos>
References: <20211107164951.wxcyp7iar2s4mjkn@nixos>
	<CABUevEz5X8qSCNEveNOU19Gy3FcOXdRgpP=Z33KUbDw=DNs_cA@mail.gmail.com>
	<20211109225734.7evav44x7nf5c5jb@nixos>

On Tue, Nov 9, 2021 at 11:57 PM Nils Andre <[email protected]> wrote:

> Hi,
>
> On Mon, Nov 08, 2021 at 10:03:50AM +0100, Magnus Hagander wrote:
> > Yeah, I think the fact that it says bash is just a "knee-jerk default"
> and
> > not that it ever did either. So I have no problem changing that to sh.
> I'm
> > a bit curious though, as to in which scenario this actually causes a
> > problem?
>
> This causes problems on [NixOS][1] which only has `/bin/sh` and
> `/usr/bin/env` in the location one would "expect" them.
>

Hmm. Interesting. Anyway, this part seems perfectly fine to fix.


> The second change I'm less sure about. There are many different things you
> > could change to break a script. This is one of them. You could change
> PATH,
> > or you could replace "find" or "xargs" with commands that don't work the
> > same way. CDPATH is not a variable that should, I believe, ever be
> exported
> > into non-interactive scripts in the first place.
>
> I didn't realise I was exporting CDPATH, which is ~~probably~~ a mistake
> (and would have prevented previous painful and long headaches).
>

I'm pretty sure that one will break a lot of other things...


For what it's worth, I use a program I have written that makes use of
> CDPATH (and hence requires it to be exported (but I think I will
> reconsider the program's usage of CDPATH)).
>

I would recommend that :)


However I do understand this is an issue with my particular setup.
>
> Attached, is the patch amended without the CDPATH change.
>
>
Thanks, applied as such!

//Magnus

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Improve portability of pgweb/load_initial_data.sh
  In-Reply-To: <CABUevEyR-jfGWquPTCNpBiw+O_tmHT1xi+9HbYJuXFqjwzu_dQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox