From: Karl O. Pinc <kop@karlpinc.com>
To: Greg Stark <stark@mit.edu>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Gregory Stark (as CFM) <stark.cfm@gmail.com>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: w^3 <pgsql-www@lists.postgresql.org>
Subject: Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Date: Tue, 14 Mar 2023 16:29:19 -0500
Message-ID: <20230314162919.7342db4d@slate.karlpinc.com> (raw)
In-Reply-To: <CAM-w4HPOTYTML1md2zom9evVyFqt26JQdcrKNgm-gW7VUROoNw@mail.gmail.com>
References: <20230309183647.jvgez7ottssjcmav@alvherre.pgsql>
<921d14b9-4aed-440c-cbef-0c6ab4648ca3@postgresql.org>
<CAM-w4HNsYCGSxm7jL=ibXQz4Ropx7EAqbY3vhsMZi+NO1GMtgQ@mail.gmail.com>
<CAM-w4HObCOZfa4UZOv1bins=DkOWrMYJFaZXUDW0W_0DRC4O6A@mail.gmail.com>
<CAM-w4HPOTYTML1md2zom9evVyFqt26JQdcrKNgm-gW7VUROoNw@mail.gmail.com>
On Tue, 14 Mar 2023 13:57:57 -0400
Greg Stark <stark@mit.edu> wrote:
> Sorry, having read the whole thread I think it's clear. The source
> tree patch was committed by Alvaro H in
> a7e584a7d68a9a2bcc7efaf442262771f9044248 and then Katz pushed the
> pgweb change. So I gather this is resolved now and I've marked it
> committed by Alvaro.
There remains an un-committed patch from this thread/commitfest
entry:
v10-0002-Page-break-before-sect1-in-contrib-appendix-when-pdf.patch
When generating the PDF docs it starts each contrib entry on
a separate page.
From:
https://www.postgresql.org/message-id/20230122144246.0ff87372%40slate.karlpinc.com
I've re-attached the patch. Nobody has commented directly
on this particular patch, although there was a "looks ok" reply
to the email.
I don't know what the policy is now that the commitfest entry
is closed. Perhaps Alvaro was planning on committing it?
Please let me know if I should open up a new
commitfest entry or if there is something else I need to do.
Thanks for the help.
Regards,
Karl <kop@karlpinc.com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
Attachments:v10-0002-Page-break-before-sect1-in-contrib-appendix-when-pdf.patch (text/x-patch, 479B) downloaddiff --git a/doc/src/sgml/stylesheet-fo.xsl b/doc/src/sgml/stylesheet-fo.xslindex 0c4dff92c4..68a46f9e24 100644--- a/doc/src/sgml/stylesheet-fo.xsl+++ b/doc/src/sgml/stylesheet-fo.xsl@@ -132,4 +132,12 @@
</fo:bookmark>
</xsl:template>
+<!-- Every sect1 in the appendix describing contributed modules+ gets a page break -->++<xsl:template match="id('contrib')/sect1">+ <fo:block break-after='page'/>+ <xsl:apply-imports/>+</xsl:template>+
</xsl:stylesheet>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-www@postgresql.org
Cc: kop@karlpinc.com, stark@mit.edu, alvherre@alvh.no-ip.org, stark.cfm@gmail.com, jkatz@postgresql.org, daniel@yesql.se, pgsql-www@lists.postgresql.org
Subject: Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
In-Reply-To: <20230314162919.7342db4d@slate.karlpinc.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox