pg.ddx.io  pgsql-www@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Subject: Re: Bogus reports from coverage.postgresql.org
Date: Sun, 11 Mar 2018 15:24:37 -0400
Message-ID: <2633.1520796277@sss.pgh.pa.us> (raw)
In-Reply-To: <1594.1520795000@sss.pgh.pa.us>
References: <30022.1520642188@sss.pgh.pa.us>
	<d0eec0fd-bf3b-55da-f5de-4fa1c00ce400@2ndquadrant.com>
	<CABUevEyydszbZJPF6iyjU45C+Kx4YSCa+KDZJkXNdjiGbE0Ojg@mail.gmail.com>
	<30195.1520790475@sss.pgh.pa.us>
	<30669.1520791101@sss.pgh.pa.us>
	<CABUevEx5Q0YEPrsdUL75BB0z+Ns3m7eX=x3oRwttjHRJ0HeQRw@mail.gmail.com>
	<31446.1520791925@sss.pgh.pa.us>
	<1594.1520795000@sss.pgh.pa.us>

I wrote:
> Huh.  7.3.1 shows the bug.

Wait, scratch that, I misread it.  The gcov output on 7.3.1 looks like

     4127:  478:                                case CLASS_ATOM:
        -:  479:
        -:  480:                                        /*
        -:  481:                                         * atom => atom is the base case
        -:  482:                                         */
        -:  483:                                        return
     4127:  484:                                                predicate_implied_by_simple_clause((Expr *\
) predicate,
call    0 returned 100%
        -:  485:                                                                                          \
                         clause,
        -:  486:                                                                                          \
                         weak);
        -:  487:                        }
    #####:  488:                        break;
        -:  489:        }
        -:  490:
        -:  491:        /* can't get here */
    #####:  492:        elog(ERROR, "predicate_classify returned a bogus value");
call    0 never executed
call    1 never executed
call    2 never executed
        -:  493:        return false;
        -:  494:}
        -:  495:
        -:  496:/*----------
        -:  497: * predicate_refuted_by_recurse

which is correct: it's showing that the elog line is never executed.

So apparently, this bug is specific to gcc 6.3.0 and maybe a few
versions on either side of that.

			regards, tom lane




view thread (44+ messages)  latest in thread

Message-ID: <2633.1520796277@sss.pgh.pa.us>
Permalink:  ../2633.1520796277@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2633.1520796277@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: tgl@sss.pgh.pa.us, magnus@hagander.net, peter.eisentraut@2ndquadrant.com, pgsql-www@lists.postgresql.org
  Subject: Re: Bogus reports from coverage.postgresql.org
  In-Reply-To: <2633.1520796277@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox