pg.ddx.io  pgsql-www@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jonathan S. Katz <jkatz@postgresql.org>
To: Christoph Berg <myon@debian.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-www@lists.postgresql.org, Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: PostgreSQL Contributors <contributors@lists.postgresql.org>
Subject: Re: Introduce contributor badges
Date: Tue, 13 Oct 2026 22:05:26 -0400
Message-ID: <329b5d0e-44ba-4c5f-8cc9-c9eb5424955b@postgresql.org> (raw)
In-Reply-To: <aszgh1hJGT6bG7QU@msg.df7cb.de>
References: <aszgh1hJGT6bG7QU@msg.df7cb.de>

Hi,

Thanks for working on this. I can provide some review on the current 
patches.

On 10/12/26 9:28 AM, Christoph Berg wrote:

> What do you think about the open ends?
> 
> Attachments:
> v12-0001-Contributor-copy-editing.patch - the stuff from this mail

While looking at the text edits, I saw that we're storing the badge 
binary in the database. This would be a first for .org; typically we 
store these in the repo, so we can leverage whatever cache/CDN 
mechanisms we have. While the code is pretty neat, IMV it'd be better to 
store it in our standard image directory.

If there's a reason for this to be in the database, please let me know. 
I also know this is one of those things that we can ultimately change.

The rest of this looks OK.

> v12-0001-Make-contributor-badges-discoverable.patch - what will
>    actually put the badges live

I guess I missed why we're separating out Contributors + People, but if 
it's agreed upon I don't have too strong of an opinion. Otherwise just 
looking at it, I'm confused at the difference :) Maybe we have to also 
retitle "Contributors" to "Recognized Contributors", i.e.

-         {'title': 'Contributors', 'link': '/community/contributors/'},
+         {'title': 'Recognized Contributors', 'link': 
'/community/contributors/'},

(which also matches the new title of the page)

The rest LGTM.

> v12-0001-Extend-badge-title-to-64-chars.patch - future database fix

I don't think we need to be stingy on the characters here; I think the 
"default" we've used is 255; let's just be safe. (I'm also OK if we 
don't use TextField given these will typically be short).


> Assuming v12-0001-Contributor-copy-editing.patch is ok, would you
> think that we can proceed with adding some badges now? My hope would
> be to have at least "PostgreSQL 18 Contributor" live for Valencia.
> 
> Timeline:
> after ack: apply v12-0001-Contributor-copy-editing.patch
> this week: create initial badges, add holders
>             have badges approved in moderation (they are still not visible)
> shortly before the conference: apply v12-0001-Make-contributor-badges-discoverable.patch
> later: apply v12-0001-Extend-badge-title-to-64-chars.patch
Thanks,

Jonathan


Attachments:

  OpenPGP_signature.asc (application/pgp-signature, 839B) download

view thread (45+ messages)  latest in thread

Message-ID: <329b5d0e-44ba-4c5f-8cc9-c9eb5424955b@postgresql.org>
Permalink:  ../329b5d0e-44ba-4c5f-8cc9-c9eb5424955b@postgresql.org/
Also on:    postgresql.org/message-id/329b5d0e-44ba-4c5f-8cc9-c9eb5424955b@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-www@postgresql.org
  Cc: jkatz@postgresql.org, myon@debian.org, daniel@yesql.se, magnus@hagander.net, x4mmm@yandex-team.ru, melanieplageman@gmail.com, contributors@lists.postgresql.org
  Subject: Re: Introduce contributor badges
  In-Reply-To: <329b5d0e-44ba-4c5f-8cc9-c9eb5424955b@postgresql.org>
  References: <aszgh1hJGT6bG7QU@msg.df7cb.de> <329b5d0e-44ba-4c5f-8cc9-c9eb5424955b@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox