public inbox for [email protected]  
help / color / mirror / Atom feed
From: Célestin Matte <[email protected]>
To: [email protected]
Subject: Re: [PATCH] pgweb: Search: bugfix: replace sites.baseurl with sites.hostname
Date: Mon, 25 Oct 2021 18:19:49 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABUevExDQhiAwL7qAKR1=DFmrFVzb+zHKpfurUo8P78hoATe6A@mail.gmail.com>
References: <[email protected]>
	<CABUevExDQhiAwL7qAKR1=DFmrFVzb+zHKpfurUo8P78hoATe6A@mail.gmail.com>

Hello,

> But short term, I believe the correct thing to do is to add the baseurl field to the table in the SQL file. I'll go push a patch taht does that.

This broke data.sql as baseurl is NOT NULL. Attached patch fixes that.
This might have also broken the crawler but I haven't installed it to test that.

Cheers,
-- 
Célestin Matte

Attachments:

  [text/x-patch] 0001-Fix-data.sql-after-addition-of-baseurl-in-52455885.patch (1.4K, 2-0001-Fix-data.sql-after-addition-of-baseurl-in-52455885.patch)
  download | inline diff:
From 0e876a52caf70dfa9f0bc3b6bbf2668be0258fe2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9lestin=20Matte?= <[email protected]>
Date: Mon, 25 Oct 2021 18:16:48 +0200
Subject: [PATCH] Fix data.sql after addition of baseurl in 52455885

---
 tools/search/sql/data.sql | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/search/sql/data.sql b/tools/search/sql/data.sql
index 5e12e9d2..64be2429 100644
--- a/tools/search/sql/data.sql
+++ b/tools/search/sql/data.sql
@@ -1,11 +1,11 @@
-INSERT INTO sites (id, hostname, description, pagecount)
- VALUES (1, 'www.postgresql.org', 'Main PostgreSQL Website', 0);
+INSERT INTO sites (id, hostname, baseurl, description, pagecount)
+ VALUES (1, 'www.postgresql.org', 'https://www.postgresql.org', 'Main PostgreSQL Website', 0);
 
-INSERT INTO sites (id, hostname, description, pagecount)
- VALUES (2, 'www.pgadmin.org','pgAdmin III', 0);
+INSERT INTO sites (id, hostname, baseurl, description, pagecount)
+ VALUES (2, 'www.pgadmin.org', 'https://www.pgadmin.org', 'pgAdmin III', 0);
 
-INSERT INTO sites (id, hostname, description, pagecount)
- VALUES (3, 'jdbc.postgresql.org','JDBC driver', 0);
+INSERT INTO sites (id, hostname, baseurl, description, pagecount)
+ VALUES (3, 'jdbc.postgresql.org', 'https://jdbc.postgresql.org', 'JDBC driver', 0);
 
 
 INSERT INTO site_excludes VALUES (2,'^/archives');
-- 
2.33.1



view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCH] pgweb: Search: bugfix: replace sites.baseurl with sites.hostname
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox