public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Célestin Matte <[email protected]>
To: Jonathan S. Katz <[email protected]>
Cc: PostgreSQL WWW <[email protected]>
Subject: Re: [PATCH] pgweb: Search: bugfix: replace sites.baseurl with sites.hostname
Date: Wed, 27 Oct 2021 15:47:59 +0200
Message-ID: <CABUevEw6rNMzaZPooV+WPZ9RTn9af9WLqFD-vR_RCYL56HJapQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CABUevExDQhiAwL7qAKR1=DFmrFVzb+zHKpfurUo8P78hoATe6A@mail.gmail.com>
	<[email protected]>

On Mon, Oct 25, 2021 at 6:19 PM Célestin Matte <[email protected]>
wrote:

> Hello,
>
> > But short term, I believe the correct thing to do is to add the baseurl
> field to the table in the SQL file. I'll go push a patch taht does that.
>
> This broke data.sql as baseurl is NOT NULL. Attached patch fixes that.
> This might have also broken the crawler but I haven't installed it to test
> that.
>

Indeed it does. Oops.

That said, most of that file are not-current examples, and should just be
cleaned out, so I'll do that while fixing this.

Yeah, another sign that this needs some proper spring cleaning to get rid
of configuration of the flexibility that we don't care about. But tihs one
for now, to unbreak things short-term.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] pgweb: Search: bugfix: replace sites.baseurl with sites.hostname
  In-Reply-To: <CABUevEw6rNMzaZPooV+WPZ9RTn9af9WLqFD-vR_RCYL56HJapQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox