public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexey Borzov <[email protected]>
To: Omar Kilani <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Language selection based on browser preference,
Date: Wed, 17 Nov 2004 13:01:20 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Hi,
Omar Kilani wrote:
> Attached patch:
>
> * Picks a language based on the actual browser preference.
> * Makes all pages default to UTF-8.
> * Adds language direction support.
> * Makes pages tell the browser what language they're in.
> * Fixes language_map.
> * Adds a couple of extra handy language functions.
I have some questions regarding the patch:
1) What's the purpose of adding the encoding to the HTML? It's already
defined in .htaccess and having it in HTML may lead to some problems.
2) All files are expected to be in UTF-8, so is there a reason to encode
Cyrillic letters in HTML entitites?
3) The language_from_accept_language() function does not seem to handle
quality values for preferred languages, as described f.e. here:
http://httpd.apache.org/docs/content-negotiation.html
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH] Language selection based on browser preference,
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox