public inbox for [email protected]  

help / color / mirror / Atom feed

From: Guillaume Lelarge <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: [email protected]
Subject: Re: Typos fixes and an accesskey
Date: Thu, 05 Apr 2007 00:26:49 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Magnus Hagander a écrit :
> Guillaume Lelarge wrote:
>> Hi,
>>
>> I send again my patchs because they don't seem to appear on the mailing
>> list. I just hope you won't receive the two same messages.
>>
>> You'll find attached a .tar.gz which contains two patches.
>>
>>
>> The first one, typos.patch, fixes a few typos I found while translating
>> the templates. Please, review them because I'm not a native english
>> speaker.
> 
> This patch appears to contain a whole lot of changes that are just
> whitespace (such as the indention). That makes it much harder to find
> out what has really changed. Can you submit it without the whitespace
> changes?
> 

I don't remember there was a lot of whitespace changes. I'll take a look 
and re-submit it.

> 
>> The second one, searchaccesskey.patch, adds an accesskey (q) for the
>> search text box field. It's a quick way to access this text box. You can
>> change the key if you want but I would really like to see an access key
>> on this field.
> 
> I'm not really sure about what you can and can not do with accesskeys,
> but is there a particular reason you chose "q" for the search feature?
> Seems like "s" would be a more logical choice?
> 

An access key is just a shortcut. On firefox, I think you have to use 
Alt-Shift and the key. For example, with this patch Alt-Shit-q and your 
cursor goes to the search text field.

q for query, q is the id of the field (not really a good reason :) ).

s is fine for me :)

I don't mind which letter is used as long as there's an accesskey.


-- 
Guillaume.
<!-- http://abs.traduc.org/
      http://lfs.traduc.org/
      http://docs.postgresqlfr.org/ -->

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Typos fixes and an accesskey
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox