public inbox for [email protected]  

help / color / mirror / Atom feed

From: Zdenek Kotala <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: New idea for patch tracking
Date: Sat, 05 May 2007 16:24:38 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

I would like to add one point:

Bruce Momjian wrote:

> 
> Patch committers check several things before applying a patch:
> 
> 1)  Follows the SQL standard or community agreed-upon behavior
> 2)  Style merges seamlessly into the surrounding code
> 3)  Written as simply and efficiently as possible
> 4)  Uses the available PostgreSQL subsystems properly
> 5)  Contains sufficient comments
> 6)  Contains code that works on all supported operating systems
> 7)  Has proper documentation
> 8)  Passes all regression tests

   8.5) Contains regression test(s) which covered performed changes

> 9)  Behaves as expected, even under unusual cirumstances
> 10)  Contains no reliability risks
> 11)  Does not overly complicate the source code
> 12)  If performance-related, it should have a measureable performance benefit
> 13)  Is of sufficient usefulness to the average PostgreSQL user
> 14)  Follows existing PostgreSQL coding standards
> 


	Zdenek

view thread (98+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: New idea for patch tracking
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox