public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Guillaume Lelarge <[email protected]>
Cc: PostgreSQL www <[email protected]>
Subject: Re: Patch to make some strings available to translations
Date: Fri, 14 Mar 2008 23:57:33 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Guillaume Lelarge wrote:
> Guillaume Lelarge a écrit :
>> I already sent this patch a few months before, but didn't get an 
>> answer on it. So, I updated it and hope for the best :)
>>
>> Anyways, a few words on one file of this patch. I had to change 
>> system/global/pgpage.php in two ways.
>>
>> First, to add '.UTF-8' to the locale. Without, I couldn't get any 
>> gettext translation to work. I wonder if Adrian had to do the same for 
>> his translation. I don't think the way I did it is absolutely right, 
>> so I would like comments on this.
>>
>> Second, base_href is set to http://www.postgresql.org/, making any 
>> links go to the official website. I'm wondering why we didn't use the 
>> value of $_SETTINGS['hosted_url'] for example as it can be a local 
>> setting.
>>
>> Any comments ? better ways to solve these ?
>>
> 
> I forgot something. "tools/schema.sql" seems to be the schema of the 
> pgweb database. Unfortunately, it doesn't seem up to date... at least, 
> the organisation column is missing on the events table.

Yeah, that's a known problem. I'm working with JD (I hope) to get it set 
up so it'll automatically be committed there from the production db.

//Magnus

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Patch to make some strings available to translations
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox