public inbox for [email protected]  
help / color / mirror / Atom feed
From: Stefan Kaltenbrunner <[email protected]>
To: Magnus Hagander <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: Célestin Matte <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] pgarchives: parser: handle messages in which Message-ID is missing
Date: Fri, 5 Nov 2021 21:44:33 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABUevEyhYyx4DJ_7kENZry2wwZYz9R4J_oh8f0cKkUY+3Q8Kfw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CABUevEyhYyx4DJ_7kENZry2wwZYz9R4J_oh8f0cKkUY+3Q8Kfw@mail.gmail.com>

On 11/4/21 10:07 PM, Magnus Hagander wrote:
> 
> 
> On Thu, Nov 4, 2021 at 8:47 PM Alvaro Herrera <[email protected] 
> <mailto:[email protected]>> wrote:
> 
>     On 2021-Nov-04, Célestin Matte wrote:
> 
>      > > I don't think this should be the responsibility of pglister. As you
>      > > say, "most MTAs do add this field" -- and the solution is to
>      > > configure the MTA to do this. We already rely on the MTA to get a
>      > > lot of other important things right.
>      >
>      > But then these messages will get delivered by pglister but pgarchives
>      > will fail to archive them, although they do not actually break
>      > requirements. Shouldn't we follow the RFC here?
> 
> 
> I agree that the scenario is a problem, per below.  I don't agree that 
> making up an id is a solution to that problem.
> 
> 
>     Maybe pglister should refuse to deliver messages that don't contain
>     a Message-Id.
> 
> 
> It should. I actually thought it did already, but apparently it does 
> not. I guess we've only ever used it under properly configured MTAs :)
> 
> Have you actually come across any case where a *proper* non-spam message 
> is sent without a message-id and passes through actual mailservers on 
> the way?
> 
> Looking through the approximately 1.4 million mails in the postgres list 
> archives, not a single one has a message-id generated by the archives 
> server MTA (which is configured to generate it). Not a single one by our 
> inbound relay servers. And exactly one by the pglister server -- which 
> turns out to be a bounce that ended up in the archives because of a 
> misconfiguration back in 2018 that's not visible in the public archives.

as mentioned down-thread by Justin Clift we have been plain rejecting 
mails without a message-id on the postgresql.org inbound relays since 
March 27th 2012(!) according to our repo and the number of rejects due 
to that rule is actually not-insignificant (approximately 200-400/day 
with the majority being for a very small number of bounce generating 
senders) but the number of complaints is also approaching (almost) zero.

So the reason why pglister is not seeing them a lot is because we dont 
accept them upstream, not that they dont exist in the wild...

Though the ones in the wild seem to be "not very useful"...



Stefan

Stefan





view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] pgarchives: parser: handle messages in which Message-ID is missing
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox