public inbox for [email protected]
help / color / mirror / Atom feedFrom: Célestin Matte <[email protected]>
To: PostgreSQL WWW <[email protected]>
Subject: Patches waiting for review/integration (pglister, pgarchives, pgweb)
Date: Mon, 12 Feb 2024 21:48:58 +0100
Message-ID: <[email protected]> (raw)
Hello,
I've been sending patches for pglister and pgarchives since 2021, and some of them seem to have been overlooked.
Would it be possible to have a feedback on these patches, or pushing the ones already reviewed to master?
Hopefully this list will help sorting through the opened discussions.
- pglister: make organization name generic
https://www.postgresql.org/message-id/[email protected]
Final patches here: https://www.postgresql.org/message-id/9bea3703-57a6-db28-907a-465fb891a44a%40cmatte.me
Status: General idea was approved, final series of patches did not get a response
- pgarchives: Bugfix: missing ids in pglister_sync
https://www.postgresql.org/message-id/[email protected]
Patch here: https://www.postgresql.org/message-id/CABUevEyo3T2QY9sEFvthmNd2vYRzUnESWZ%3Di9GaotQsyhuEQww%40mail.g...
Status: Magnus wrote a patch, I tested and approved it, but it was never pushed to master
Possible commit message:
Bugfix: missing ids in pglister_sync
groupid and listid are not explicitly set in pglister_sync's queries, which
causes the script to fail as these fields are NOT NULL and postgresql default
configuration does not auto-fill id fields.
- pglister: Add README.md and INSTALL.md
https://www.postgresql.org/message-id/[email protected]
Status: never got a review
- pgarchives: Always load auth, even when using PUBLIC_ARCHIVES=True
https://www.postgresql.org/message-id/[email protected]
Final patch here: https://www.postgresql.org/message-id/846c9d77-bfff-19e3-9622-eaad5f9bf7b0%40cmatte.me
Status: New patch sent following review, but never reviewed/integrated
- pgarchives: Add search front-end from pgweb
https://www.postgresql.org/message-id/[email protected]
Status: It was acknowledged that there could be an interface in the archives code, but this patch was never reviewed (it's a big patch)
- pgarchives: merge schema.sql into Django's model
https://www.postgresql.org/message-id/[email protected]
Final patches here: https://www.postgresql.org/message-id/a31a7071-7338-4423-a8e5-16d70f19c2c8%40cmatte.me
Status: I've been told that this big patch should be written in place of smaller ones that fixed existing issues. I've had this in production for two years and fixed issues that have arisen. It's working great now. Still waiting for a review.
- auth.py: make it possible to customize email address in error message
pgweb: https://www.postgresql.org/message-id/[email protected]
pglister & pgarchives: https://www.postgresql.org/message-id/ae313e50-5ae1-4285-af2b-9d4b48b2f76a%40cmatte.me
Status: Got a response on the first patch, waiting for review/integration for all of them
- pglister: gitlab-ci: bump tool for syntax checking
+ pgarchives: Convert tools/ scripts to python3
https://www.postgresql.org/message-id/152870d5-4443-4a72-aabd-ee3506447926%40cmatte.me
Status: I sent these corrective patches to address comments, but they were not integrated
I also still think that the gitlab CI in the original message would help to quickly detect issues
- pgarchives & pglister: pglister_sync: import lists with subscriber_access set to True
https://www.postgresql.org/message-id/[email protected]
Final patches here: https://www.postgresql.org/message-id/a99938be-c9ad-8d94-0a16-8305e6391f1e%40cmatte.me
Status: I just relaunched the discussion as the patches I sent did not satisfy requirements
Regards,
--
Célestin Matte
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Patches waiting for review/integration (pglister, pgarchives, pgweb)
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox