public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Melanie Plageman <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Bossart, Nathan <[email protected]>
Subject: Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section
Date: Thu, 9 Jan 2025 17:23:11 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAKRu_ZR8aqiZ0SHK8Rqd7QVAmr6XX9Xpkie9vmZAkyb69YOiQ@mail.gmail.com>
References: <CAAKRu_aQUOaMYrcjNuXeSkJtaX9oRUzKP57bsYbC0gVVWS+cbA@mail.gmail.com>
	<[email protected]>
	<CAAKRu_bz3BD4w0jmjfQkckAQE5eb-Ge2a=9Q-HG_rWSTeG_PzA@mail.gmail.com>
	<CAAKRu_Ymux_RBzp5faSR5-qx1JdM6qS3POVjcWyHbnQjzgmo8g@mail.gmail.com>
	<[email protected]>
	<CAAKRu_ZR8aqiZ0SHK8Rqd7QVAmr6XX9Xpkie9vmZAkyb69YOiQ@mail.gmail.com>

On 09.01.25 02:45, Melanie Plageman wrote:
> On Wed, Jan 8, 2025 at 8:39 AM Peter Eisentraut <[email protected]> wrote:
>>
>> On 07.01.25 18:31, Melanie Plageman wrote:
>>>
>>> Oh, one thing I forgot to say. Though I increased the indentation of
>>> some of the subsections that I moved, I didn't rewrap the lines
>>> because they were already not wrapped to 78. I can do this, but I
>>> can't tell from the existing docs what text width the paragraphs of
>>> text are supposed to be wrapped to.
>>
>> For a patch that moves things around like this, I would leave everything
>> as is and not rewrap.  That makes it easier to follow what's going on
>> with "git diff -w", "git show -w" etc.
>>
>> In .dir-locals.el, there is this configuration for Emacs:
>>
>>    (nxml-mode . ((fill-column . 78)
>>                  (indent-tabs-mode . nil)))
>>
>> So that's one data point about what the line length should be.
> 
> Well, in this case, the diff won't look different with git show/diff
> -w because moving them to another part of the file is more than a
> whitespace change.

Correct.  The right option is

     git diff --color-moved

This can also be put into .gitconfig.

view thread (21+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox