agora inbox for pgsql-www@postgresql.org  
help / color / mirror / Atom feed
From: Jonathan Gonzalez V. <jonathan@abdiel.eu>
To: pgsql-www@postgresql.org
Subject: Bug during logout
Date: Mon, 10 Aug 2026 11:36:03 +0200
Message-ID: <874ih29v24.fsf@abdiel.eu> (raw)

Hello!!

Yesterday Jonathan S. Katz solved my issue with my account unlinking the
OAuth, with that I find out that the logout link isn't working because I
get a 405 when I click on it and I still logged in.

The following patch fix that issue, by adding the post method to the
pgweb/util/contexts.py and templates/base/page.html.

Django deprecated the GET method for the logout in 4.1[0] so mostly
probably this was a leftover of a migration. Giving that this could
happen again, I've added a test for that too.

Also, there's a change in the CSS that makes the button inside the form
to look like a link.

Regards!!

[0] https://docs.djangoproject.com/en/dev/releases/4.1/#log-out-via-get
--
Jonathan Gonzalez V.
EDB https://www.enterprisedb.com

Attachments:

  [text/x-diff] 0001-Turn-the-logout-link-into-a-POST-method-following-Dj.patch (0B, ../874ih29v24.fsf@abdiel.eu/2-0001-Turn-the-logout-link-into-a-POST-method-following-Dj.patch)
  download

view thread (6+ messages)  latest in thread

Message-ID: <874ih29v24.fsf@abdiel.eu>
Permalink:  ../874ih29v24.fsf@abdiel.eu/
Also on:    postgresql.org/message-id/874ih29v24.fsf@abdiel.eu

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: jonathan@abdiel.eu
  Subject: Re: Bug during logout
  In-Reply-To: <874ih29v24.fsf@abdiel.eu>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox