public inbox for [email protected]
help / color / mirror / Atom feedFrom: Magnus Hagander <[email protected]>
To: Dave Page <[email protected]>
Cc: PostgreSQL WWW <[email protected]>
Subject: Re: Copy script button cleanup
Date: Wed, 3 Dec 2025 23:28:55 +0100
Message-ID: <CABUevEw4DSsQemiDxn2WQffp2J+1Q7iEBuBTx_zNwf5tqgg6Rg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyE1J2hY7tR=mw+ikQSPbD61ftjouk4fkvkmA4qfaODDA@mail.gmail.com>
References: <CA+OCxoxH75C4Q79bOfxpwXJtgZxjgTtR1xa+cWL0NVBNnT_OyA@mail.gmail.com>
<CABUevExmHVYwddKvFUWkjY8Ev-xAE2p0-mP0wJqJDs1bazMn7A@mail.gmail.com>
<CA+OCxoyE1J2hY7tR=mw+ikQSPbD61ftjouk4fkvkmA4qfaODDA@mail.gmail.com>
On Wed, 3 Dec 2025 at 11:38, Dave Page <[email protected]> wrote:
>
>
> On Tue, 2 Dec 2025 at 14:41, Magnus Hagander <[email protected]> wrote:
>
>>
>>
>> On Tue, 2 Dec 2025 at 12:30, Dave Page <[email protected]> wrote:
>>
>>> The Copy Script buttons on the Linux package installation pages look
>>> horrific. See before.png.
>>>
>>> The attached patch makes them look much nicer, with proper sizing and an
>>> icon based button. On click, it briefly changes to a green checkmark to
>>> show confirmation. See the after screenshots.
>>>
>>> I'll apply this in a couple of days if there are no objections.
>>>
>>>
>> LGTM in general and certainly is a lot prettier.
>>
>> Can you explain what that "fallback for text based buttons" is? Aren't
>> they all replaced with icons?
>>
>
> Oh, yeah. That's no longer needed now the patch is complete. I'll remove
> it.
>
>
>>
>> Oh, and I'm told you're not supposed to use "var" for variables in js due
>> to the broken scoping :)
>>
>
> Old habits die hard :-(
>
>
>>
>> And while you're poking at it, one thing I've really wanted is a "copy
>> without the sudo parts". But I'm guessing that would be a lot more
>> complicated than what you're fixing here...
>>
>
> Ask and thou shalt receive.
>
Sweet! :)
2 patches attached. Both fix the original issue. One also adds the no sudo
> button.
>
>
Looks good in a (fairly brief) check. Thanks!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Copy script button cleanup
In-Reply-To: <CABUevEw4DSsQemiDxn2WQffp2J+1Q7iEBuBTx_zNwf5tqgg6Rg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox