public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Célestin Matte <[email protected]>
To: Jonathan S. Katz <[email protected]>
Cc: PostgreSQL WWW <[email protected]>
Subject: Re: [PATCH] pgarchives: Fix database install procedure: remove redundant tables in schema.sql
Date: Sat, 23 Oct 2021 16:30:43 +0200
Message-ID: <CABUevEwxztRLDWNxBuQmAmFYcRHLsxv-dZ1BHWU4_ZLAy0G1nA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Fri, Oct 22, 2021 at 5:20 PM Célestin Matte <[email protected]>
wrote:

> Hello,
>
> Apologies, patch sent in previous email of this thread is incorrect.
> Please find correct patch attached.
>
> In fact, the pgarchives repository is in a weird state, in which the
> migration adding two tables is missing
> (0005_apiclient_threadsubscription.py when running makemigrations). My
> guess is that this is because these tables use SERIALs, which django does
> not handle properly, and must by created using raw SQL. Am I right?
> Is it something that should be fixed?
>

Ugfh, yeah that one is really embarrassing on my part, and I thought I'd
cleaned that one up but clearly not. The whole threadsubscription part
wasn't finished, and was not supposed to be included
in 4d159ca8b4efb0b1cf0893bca63d6e9489a9095f.

The correct solution there is to revert most
of 4d159ca8b4efb0b1cf0893bca63d6e9489a9095f, to have it include only the
parts that are supposed to be there. And then reapply them at some time in
the future when the code is finished. I'll go clean that up -- thanks for
bringing my attention back to that!

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] pgarchives: Fix database install procedure: remove redundant tables in schema.sql
  In-Reply-To: <CABUevEwxztRLDWNxBuQmAmFYcRHLsxv-dZ1BHWU4_ZLAy0G1nA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox