public inbox for [email protected]  
help / color / mirror / Atom feed
From: Magnus Hagander <[email protected]>
To: Célestin Matte <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] pgarchives: parser: handle messages in which Message-ID is missing
Date: Thu, 4 Nov 2021 11:31:33 +0100
Message-ID: <CABUevExbE==POwr9LOESmJ-J+PvkCQ=-F6wH=1SegFUAzxfsCA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Wed, Nov 3, 2021 at 6:02 PM Célestin Matte <[email protected]>
wrote:

> Hello,
>
> As surprising as it may seem, Message-ID is actually not a mandatory email
> field [1]. While most MTAs do add this field, some might not, and this will
> cause load_message.py to crash.
> As a solution to this, when this field is missing, this patch:
> - attempts to find a "Sent-Message-ID" header and use it as the Message-ID
> (a case I encountered when trying to import an old mbox)
> - generates a new Message-ID if none exists, following (a simpler version
> of) [2].
>

I don't think this should be the responsibility of pglister. As you say,
"most MTAs do add this field" -- and the solution is to configure the MTA
to do this. We already rely on the MTA to get a lot of other important
things right.

It may be something that should get documented somewhere as a requirement.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] pgarchives: parser: handle messages in which Message-ID is missing
  In-Reply-To: <CABUevExbE==POwr9LOESmJ-J+PvkCQ=-F6wH=1SegFUAzxfsCA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox