public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Célestin Matte <[email protected]>
Cc: PostgreSQL WWW <[email protected]>
Subject: Re: [PATCH 1/2] pgarchives: Add missing authentication backend to settings.py
Date: Sat, 15 Jan 2022 18:54:20 +0100
Message-ID: <CABUevExckBnyw1cUvioswExNrR8cnyM_U12HnWMbvcGTWxYVdg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Thu, Oct 28, 2021 at 7:42 PM Célestin Matte <[email protected]> wrote:
>
> Hello,
>
> Authentication when using private archives in pgarchives is broken with current settings.py file.
> This first patch add a missing backend in settings.py, without which sessions aren't registered and users get redirected indefinitely.
> In the second patch of this series, I add missing parameters for configuring PGAUTH, copying the ones from pglister.

Yeah, technically it's configured to use django auth but then we
override that elsewhere.  It might be worthwhile to remove those
hardcoded redirects and make it possible to use the system with the
built in django auth. But until someone does that, I agree that
putting a working value into AUTHENTICATION_BACKEND is definitely
better.

And also the example file that was in your patch #2.

Both patches squashed and applied. Thanks!

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH 1/2] pgarchives: Add missing authentication backend to settings.py
  In-Reply-To: <CABUevExckBnyw1cUvioswExNrR8cnyM_U12HnWMbvcGTWxYVdg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox