public inbox for [email protected]
help / color / mirror / Atom feedFrom: Magnus Hagander <[email protected]>
To: Célestin Matte <[email protected]>
Cc: PostgreSQL WWW <[email protected]>
Subject: Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py
Date: Wed, 19 Jan 2022 23:30:08 +0100
Message-ID: <CABUevEy0y4vM77A_hbn8YXA6DpLx7dtbvsT+D_13gASbJNjizg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<CABUevEw+gtEVa1sq0H5FMXuYnm1EXU6mxaqLaYn42tindmCAyQ@mail.gmail.com>
<[email protected]>
On Wed, Jan 19, 2022 at 3:30 PM Célestin Matte <[email protected]> wrote:
>
> Hi,
>
> I'm reviewing the patches I sent a few months ago and this short one seems to have been left mid-discussion.
>
> > I think having a default like in this patch is better. Otherwise it could randomly connect to a database with the same name as the user for example, which might actually happen in dev scenarios. So if we want it empty we'd also need to add code to check if it's set or not before trying to use it - seems easier to set the default and have it fail :)
>
> I guess it's OK as-is, then?
Yeah, indeed that was forgotten.
Patch now conflicted with your own patch for archives frontend
address. I adjusted it for that and applied. Thanks!
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py
In-Reply-To: <CABUevEy0y4vM77A_hbn8YXA6DpLx7dtbvsT+D_13gASbJNjizg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox