public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Célestin Matte <[email protected]>
Cc: PostgreSQL WWW <[email protected]>
Subject: Re: [PATCH] pgarchives: Bugfix: allow message's parentid to be null
Date: Wed, 27 Oct 2021 15:50:08 +0200
Message-ID: <CABUevEz5VqyjTN9p684n0Zr++V_DbRHtoNE1TY0h6Nsewi-YPQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CABUevEyFpYPEHh0AAyTAsgymRKOOVA1SY_pDHPCbBQQ9BawfTA@mail.gmail.com>
	<[email protected]>

On Wed, Oct 27, 2021 at 12:04 PM Célestin Matte <[email protected]>
wrote:

> >
> > That said, I think the correct solutoin is still, as I mentioned in one
> of the other threads, to completely move everything into the initial
> migration, instead of doing a piecemeal hack that's going to result in a
> lot of small migrations for no real reason. We should  just accept that the
> existing one is broken and replace it.
>
> Can everything be moved to django's model though? The schema.sql file
> defines several other components (indexes, text search configurations, text
> search dictionaries, functions, triggers) and I'm not sure django is able
> to handle all of that by itself. Is it? Or do you only want to move tables?
>

The models can't handle them, but migrations can.

I'm thinking similar to pglister, where we use django models to create the
parts that *can* be created, and then RunSQL() migrations to do the rest.
That way the pure SQL parts can still run as part of the same flow, and can
be mixed in with the django generated ones. The end result in the database
should be the same, but avoiding to have to maintain a separate .sql file
for it to keep in sync.

I suggest moving everything, for that reason -- to ensure the order of
application.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] pgarchives: Bugfix: allow message's parentid to be null
  In-Reply-To: <CABUevEz5VqyjTN9p684n0Zr++V_DbRHtoNE1TY0h6Nsewi-YPQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox