public inbox for [email protected]help / color / mirror / Atom feed
Removing deprecated HTML from the security page 3+ messages / 2 participants [nested] [flat]
* Removing deprecated HTML from the security page @ 2021-10-08 13:48 Daniel Gustafsson <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Daniel Gustafsson @ 2021-10-08 13:48 UTC (permalink / raw) To: PostgreSQL WWW <[email protected]> I noticed that our security page use two deprecated constructs, the <nobr> tag (which also isn't allowed in <td> context) and the name attribute on <a>. The attached replaces the former with CSS and the latter with the recommended ID tag. -- Daniel Gustafsson https://vmware.com/ Attachments: [application/octet-stream] 0002-Replace-name-attribute-with-id.patch (891B, 2-0002-Replace-name-attribute-with-id.patch) download | inline diff: From 9eb8f0b965251d5e0d79e4ff7548c26623c08c30 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson <[email protected]> Date: Fri, 8 Oct 2021 15:41:43 +0200 Subject: [PATCH 2/2] Replace name attribute with id Use of the name attribute is deprecated, replace with the id attribute instead and place it directly on the title element. --- templates/security/security.html | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/templates/security/security.html b/templates/security/security.html index afc2dadd..5ba51e0f 100644 --- a/templates/security/security.html +++ b/templates/security/security.html @@ -99,8 +99,7 @@ You can filter the view of patches to show just patches for version:<br/> </p> -<a name="comp"></a> -<h2>Components</h2> +<h2 id="comp">Components</h2> <p> The following component references are used in the above table: </p> -- 2.24.3 (Apple Git-128) [application/octet-stream] 0001-Replace-nobr-tags-with-CSS.patch (1.5K, 3-0001-Replace-nobr-tags-with-CSS.patch) download | inline diff: From 63ad6a69e909564881da86e6d63caaaa129243de Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson <[email protected]> Date: Fri, 8 Oct 2021 15:40:24 +0200 Subject: [PATCH 1/2] Replace <nobr> tags with CSS The <nobr> tag is not allowed in <td> context, and is altogether deprecated as well. Replace with a span and a CSS class instead. --- media/css/main.css | 4 ++++ templates/security/security.html | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/media/css/main.css b/media/css/main.css index 9517ddf0..7b0609a4 100644 --- a/media/css/main.css +++ b/media/css/main.css @@ -1613,3 +1613,7 @@ table.sponsor-table tbody tr td:nth-child(3) { top: 8px; right: 8px; } + +.nobr { + white-space: nowrap; +} diff --git a/templates/security/security.html b/templates/security/security.html index 13fcc169..afc2dadd 100644 --- a/templates/security/security.html +++ b/templates/security/security.html @@ -75,7 +75,7 @@ You can filter the view of patches to show just patches for version:<br/> {%for p in patches%} <tr> <td> - {%if p.cve%}<nobr><a href="/support/security/CVE-{{ p.cve }}/">CVE-{{p.cve}}</a></nobr><br/>{%endif%} + {%if p.cve%}<span class="nobr"><a href="/support/security/CVE-{{ p.cve }}/">CVE-{{p.cve}}</a></span><br/>{%endif%} {%if p.newspost%}<a href="/about/news/{{p.newspost.title|slugify}}-{{p.newspost.id}}/">Announcement</a><br/>{%endif%} </td> <td>{{p.affected|join:", "}}</td> -- 2.24.3 (Apple Git-128) ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Removing deprecated HTML from the security page @ 2021-10-10 21:27 Magnus Hagander <[email protected]> parent: Daniel Gustafsson <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Magnus Hagander @ 2021-10-10 21:27 UTC (permalink / raw) To: Daniel Gustafsson <[email protected]>; +Cc: PostgreSQL WWW <[email protected]> On Fri, Oct 8, 2021 at 3:48 PM Daniel Gustafsson <[email protected]> wrote: > I noticed that our security page use two deprecated constructs, the <nobr> > tag > (which also isn't allowed in <td> context) and the name attribute on <a>. > The > attached replaces the former with CSS and the latter with the recommended > ID > tag. > LGTM. For 0001 I would consider maybe using a name for what it is ("cve-number") rather than what it does ("nobr"), in case we want to add on more formatting on it later. But it's such a trivial case that it probably doesn't matter until we actually have some such special formatting to add. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/; Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/; ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Removing deprecated HTML from the security page @ 2021-10-13 07:46 Daniel Gustafsson <[email protected]> parent: Magnus Hagander <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2021-10-13 07:46 UTC (permalink / raw) To: Magnus Hagander <[email protected]>; +Cc: PostgreSQL WWW <[email protected]> > On 10 Oct 2021, at 23:27, Magnus Hagander <[email protected]> wrote: > For 0001 I would consider maybe using a name for what it is ("cve-number") rather than what it does ("nobr"), in case we want to add on more formatting on it later. But it's such a trivial case that it probably doesn't matter until we actually have some such special formatting to add. I considered that too, but came to the same conclusion that it's such a small and simple class that we can deal with that when the need arises. Pushed and verified in Chrome and Firefox. -- Daniel Gustafsson https://vmware.com/ ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-10-13 07:46 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-10-08 13:48 Removing deprecated HTML from the security page Daniel Gustafsson <[email protected]> 2021-10-10 21:27 ` Magnus Hagander <[email protected]> 2021-10-13 07:46 ` Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox