From: Kevin Rocker <me@kevinrocker.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-www@lists.postgresql.org
Subject: Re: [PATCH] Disambiguate mbox download files
Date: Fri, 31 Jul 2026 16:51:43 +0200
Message-ID: <ab098339-c032-4b8e-8cf4-da799d95a45c@app.fastmail.com> (raw)
In-Reply-To: <CABUevEy0tjUs-OSuug8q1V6gZRkO_EM0a__X05d2cU9LF7_nWQ@mail.gmail.com>
References: <88954350-a993-4f2e-8cc6-c7274237b1b8@app.fastmail.com>
<CABUevEy0tjUs-OSuug8q1V6gZRkO_EM0a__X05d2cU9LF7_nWQ@mail.gmail.com>
Makes sense to me. The per-thread path already had a good filename, but was missing the file extension, so more benefits than just consistency.
On Wed, Jul 22, 2026, at 3:50 PM, Magnus Hagander wrote:
>
>
> On Thu, 25 Jun 2026 at 16:13, Kevin <me@kevinrocker.com> wrote:
>> __
>> The mailing list monthly archives were all downloading with the same filename, just "psql-hackers.mbox", which turned into "psql-hackers(1).mbox", "psql-hackers(2).mbox", etc.
>>
>> This patch sets the `Content-Disposition` header to a filename that includes the list and the year/month.
>
> I like this idea and the patch looks good. However, is there a reason not to also do this for the other code path calling _build_mbox()? If nothing else, for consistency?
>
> --
> Magnus Hagander
> Me: https://www.hagander.net/
> Work: https://www.redpill-linpro.com/Attachments:0002-Serve-per-thread-mbox-downloads-with-an-explicit-fil.patch (text/x-patch, 896B) download
From 68b61f4742bb03971ad43c86355a0dc52b4fa78a Mon Sep 17 00:00:00 2001
From: Kevin Rocker <me@kevinrocker.com>
Date: Fri, 31 Jul 2026 16:27:25 +0200
Subject: [PATCH] Serve per-thread mbox downloads with an explicit filename
Make the per-thread view consistent with the monthly downloads. Properly
set the .mbox extension/header and use the message-id as the filename.
---
django/archives/mailarchives/views.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/django/archives/mailarchives/views.py b/django/archives/mailarchives/views.pyindex fbc9731..ad1d238 100644--- a/django/archives/mailarchives/views.py+++ b/django/archives/mailarchives/views.py@@ -728,7 +728,7 @@ def message_mbox(request, msgid):
{
'thread': msg.threadid,
},
- msgid)+ msgid, filename='%s.mbox' % quote(msgid, safe=''))
@csrf_exempt
--
2.54.0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-www@postgresql.org
Cc: me@kevinrocker.com, magnus@hagander.net, pgsql-www@lists.postgresql.org
Subject: Re: [PATCH] Disambiguate mbox download files
In-Reply-To: <ab098339-c032-4b8e-8cf4-da799d95a45c@app.fastmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox