public inbox for [email protected]  

help / color / mirror / Atom feed

From: Célestin Matte <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: PostgreSQL WWW <[email protected]>
Subject: Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
Date: Sun, 31 Oct 2021 19:02:46 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABUevEx=CB6Ka1hjmidDUrsQP01QCLq=T+sLiJVTSiCDD+RQ3Q@mail.gmail.com>
References: <[email protected]>
	<CABUevEx=CB6Ka1hjmidDUrsQP01QCLq=T+sLiJVTSiCDD+RQ3Q@mail.gmail.com>

Hello,

> 
> And finally, settings.py already contains:
> try:
>     from .local_settings import *
> except ImportError:
>     pass
> 
> 
> Just a couple of lines above where you are adding it back again. Is that also for some reason not working?

Right, I missed that. It's just that in pgweb and pgarchives, the file is called settings_local.py, whereas pglister calls it local_settings.py. This is just a question of naming consistency, then. Do you think it's worth patching?

> Second, I'm not sure why we want to exclude local_settings.py from pycodestyle in general?

It's ignored in pgweb, I just assumed there was a good reason for that and did the same thing for consistency.

Cheers,
-- 
Célestin Matte

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox