From: Ksschkw (@Ksschkw) <noreply+Ksschkw@github.com>
To: pgvector/pgvector <noreply+pgvector-pgvector@github.com>
Subject: [pgvector/pgvector] PR #1056: Fixed Jaccard distance for two empty bit vectors
Date: Tue, 03 Nov 2026 13:44:22 +0000
Message-ID: <gh-pgvector-pgvector-1056@github.com> (raw)
Fixes #1043.
## The bug
`BitJaccardDistanceDefault` collapses two distinct cases into one:
```c
if (ab == 0)
return 1;
```
`ab` is the size of the intersection. When it is zero, the code cannot tell
"these vectors share no bits" from "both vectors are empty", so two identical
all-zero vectors report maximal distance while Hamming distance for the same
pair reports `0`.
Reproduced against an unmodified build:
```
identical_zero | disjoint | hamming_zero
----------------+----------+--------------
1 | 1 | 0
```
## The fix
`src/bitutils.c`: return `0` when both vectors are empty, `1` when only one is.
```c
if (ab == 0)
{
if (aa == 0 && bb == 0)
return 0;
else
return 1;
}
```
The AVX512 path accumulates `aa`/`bb` and delegates to this function, so the
one change covers both dispatch targets.
After the fix:
```
identical_zero | disjoint
----------------+----------
0 | 1
```
## Test changes
Two expected values in `test/expected/bit.out` follow the corrected behaviour:
- `jaccard_distance('0000', '0000')` changes from `1` to `0`
- `jaccard_distance('', '')` changes from `1` to `0`
Both are the same empty-set case. The disjoint cases (`'1111'` vs `'0000'`,
`'1000'` vs `'0000'`) are unchanged at `1`.
## Verification
`make installcheck` on Postgres 16, before and after:
| Build | Result |
| --- | --- |
| Without the patch, new expectation | `bit` fails, 13/14 pass |
| With the patch | **14/14 pass** |
The first row is the important one: reverting only the C change makes the
regression test fail, so the test genuinely pins the bug rather than agreeing
with the code.
## Changelog
Added a `Fixed` line under the unreleased `0.9.0` section.
inline patch 1: CHANGELOG.md, src/bitutils.c, test/expected/bit.out (+13/-3 lines) download inline-1.patchdiff --git a/CHANGELOG.md b/CHANGELOG.mdindex a724b193a..eda41606d 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -6,6 +6,7 @@
- Improved `amvalidate` for indexes
- Improved property testing for indexes
- Fixed possible error with iterative index scans during HNSW vacuuming
+- Fixed Jaccard distance for two empty bit vectors
- Dropped support for Postgres 13 and 14
## 0.8.7 (2026-10-01)
diff --git a/src/bitutils.c b/src/bitutils.cindex a83776dd6..0a7315a46 100644--- a/src/bitutils.c+++ b/src/bitutils.c@@ -124,8 +124,17 @@ BitJaccardDistanceDefault(uint32 bytes, unsigned char *ax, unsigned char *bx, ui
bb += pg_number_of_ones[bx[i]];
}
+ /*+ * An empty intersection means distance 1, unless both vectors are empty:+ * two empty sets are identical, so their distance is 0.+ */
if (ab == 0)
- return 1;+ {+ if (aa == 0 && bb == 0)+ return 0;+ else+ return 1;+ }
else
return 1 - (ab / ((double) (aa + bb - ab)));
}
diff --git a/test/expected/bit.out b/test/expected/bit.outindex 7c10bc4b8..58d4bb3b2 100644--- a/test/expected/bit.out+++ b/test/expected/bit.out@@ -107,7 +107,7 @@ SELECT jaccard_distance('1000', '0000');
SELECT jaccard_distance('0000', '0000');
jaccard_distance
------------------
- 1+ 0
(1 row)
SELECT jaccard_distance('10101010101010101010', '01010101010101010101');
@@ -137,7 +137,7 @@ SELECT jaccard_distance('1100000000000000000000000000000000000000000000000000000
SELECT jaccard_distance('', '');
jaccard_distance
------------------
- 1+ 0
(1 row)
SELECT jaccard_distance('1111', '000');