From: knizhnik (@knizhnik) <noreply+knizhnik@github.com>
To: pgvector/pgvector <noreply+pgvector-pgvector@github.com>
Subject: Re: [pgvector/pgvector] PR #86: Ivf index prefetch
Date: Sun, 21 May 2023 11:11:38 +0000
Message-ID: <gh-pgvector-pgvector-86-c1556151305@github.com> (raw)
In-Reply-To: <gh-pgvector-pgvector-86@github.com>
References: <gh-pgvector-pgvector-86@github.com>
> For 1, the current strategy was added to prevent [cache wiping](https://momjian.us/main/blogs/pgblog/2020.html#May_13_2020), but from the article, Postgres only uses `BAS_BULKREAD` when it expects to access more than 25% of the shared buffers, so we should probably do the same.
Postgres is using `BAS_BULKREAD` for seqscan but here we perform index scan.
May be my assumption is wrong, but all embedding datasets I saw (for example fro ann-banchmark) are not so large and should fit in memory. In this case filling shared buffers with this ivfflat data should not cause cache wiping and lead to faster prewarming.
Right now it is not possible to prewarm infflat index without using special extension (pg_prewarm).
>
> Let's break 1 and 2 into separate PRs to discuss.
>
> For 3 and 4, I'm not sure I'd like to add the complexity right now, but to avoid prefetching extra pages with 3, you'll want to use `IVFFLAT_LIST_EXTEND_QUANTUM` for the index build as well. You may also want to use a custom index version and prefetch conditionally to avoid prefetching extra pages with existing indexes.
I agree with you. Such aggressive prefetching is needed mostly for Neon architecture.
In case of vanilla Postgres we can rely on OS read-ahead mechanism.