agora inbox for pljava-dev@postgresql.org  

help / color / mirror / Atom feed

Subject: [Pljava-dev] readBytes() / writeBytes()
Date: Fri, 22 Sep 2006 16:42:01 +0200
Message-ID: <4513F639.3000108@tada.se> (raw)
In-Reply-To: <4513F1A0.8020800@logix-tt.com>
References: <4512F5E4.9060600@logix-tt.com>
	<45139C17.3050006@tada.se>
	<4513A107.4060809@logix-tt.com>
	<4513A3ED.3050401@tada.se>
	<4513E2C0.3050804@logix-tt.com>
	<4513E52B.5080108@tada.se>
	<4513F1A0.8020800@logix-tt.com>


Markus Schaber wrote:
> What's the best way to fix it? Using native functions for reading the
> values?
>
>   
It's two fixes basically. The endian stuff can be fixed in Java and 
directly in the SQLOutputToChunk and SQLInputFromChunk classes. The 
methods should mimic what java.nio.DirectByteBuffer does. 
java.nio.ByteOrder.nativeOrder() gives the native ordering.

The four byte offset stuff must be fixed in the C file that corresponds 
to the SQLInputFromChunk. There's no need to fix for the output since 
such a fix will introduce an ambiguity. The length is determined by the 
number of bytes written anyway, so why introduce a need to go back and 
add it. Important to document this behavior though.

I'm not too concerned with backward compatibility on this. The current 
behavior is severely broken. It must be fixed.

> I can try to contribute when you like.
>
>   
Yes, please do! Give it a try and submit a patch. My time is very 
limited these days.

Regards,
Thomas Hallgren

view thread (13+ messages)  latest in thread

Message-ID: <4513F639.3000108@tada.se>
Permalink:  ../4513F639.3000108@tada.se/
Also on:    postgresql.org/message-id/4513F639.3000108@tada.se

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pljava-dev@postgresql.org
  Subject: Re: [Pljava-dev] readBytes() / writeBytes()
  In-Reply-To: <4513F639.3000108@tada.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox