public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chapman Flack <[email protected]>
To: Kartik Ohri <[email protected]>
Cc: [email protected]
Subject: Re: the ReportScriptingMojo
Date: Fri, 14 Aug 2020 08:28:48 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAASLQ4NU9v=nuLDG-LneC68LuqKRXchFckU7mCZT9YQDNKqwvg@mail.gmail.com>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
	<[email protected]>
	<CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com>
	<CAASLQ4NHROvOq-rUz6Jn0dUd7oAq3_P655WNeqKksNBqFtAGgw@mail.gmail.com>
	<CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
	<[email protected]>
	<CAASLQ4M8cN20L7cyVEgks9qdnfsXH4ci7iQbmyi4v_y0W85eLA@mail.gmail.com>
	<[email protected]>
	<CAASLQ4MLFnD3v_fqrUj+Bwc9MSBG-ATet3J7UXebzXHTH_si3A@mail.gmail.com>
	<[email protected]>
	<CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
	<[email protected]>
	<CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
	<[email protected]>
	<CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NU9v=nuLDG-LneC68LuqKRXchFckU7mCZT9YQDNKqwvg@mail.gmail.com>

Hi Kartik,

I've made a pull request onto your 'plugin' branch. The first three
commits are some small fixes; you'll probably want to review those to
see what the issues were. The rest deals with getting the javadoc links
from one submodule to another to be generated correctly and in relative
form, so the output tree can be relocated and still work. That has been
a sticking point for years the old way, so I am glad to be able to fix it
now.

I think that if you merge that PR, that branch will be ready for a PR
onto master in the main repo. As a matter of form, it might be best to
create a new branch name, at the same point, according to the conventions
in the contribution guide [1], something like feature/master/scriptreports,
and use that branch in the pull request.

Regards,
-Chap


[1] https://github.com/tada/pljava/wiki/Contribution-guide

view thread (78+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: the ReportScriptingMojo
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox