public inbox for [email protected]
help / color / mirror / Atom feedFrom: Kartik Ohri <[email protected]>
To: Chapman Flack <[email protected]>
Cc: [email protected]
Subject: Re: PL/Java new build plugin
Date: Fri, 31 Jul 2020 02:24:12 +0530
Message-ID: <CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
<[email protected]>
<CAASLQ4M_f8cYmxfX5Jqgm9AJHsX62_Cc5pvniXjer4jAZOMOBQ@mail.gmail.com>
<CAASLQ4Pcp24U3rkWkGvcidTfCLQEsAE1it7b3Sr_uNbgO3P9kA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAASLQ4OZyt3QL5ZCH0JQyZvuOWTEOgOpko4fC+DPDXgJV0HuPw@mail.gmail.com>
<[email protected]>
<CAASLQ4PyG-YvKUTYdqfuQW8yGL+t_93b1i2CMTusoYHbZ0ZTMg@mail.gmail.com>
<CAASLQ4MDUNP_4BAqK7ZtxtqG7ErH6skMKbNRvL0vE58wdRVxiQ@mail.gmail.com>
<[email protected]>
<CAASLQ4PEcB-Rf1-vFtKCLNxVC6YZsSrzRUd_5TXZsPJp74vvcg@mail.gmail.com>
<CAASLQ4M1dg+z+J44g77cvzSe3y8q01kWbvCcgoyNzA0j=apfAA@mail.gmail.com>
<[email protected]>
<CAASLQ4POay=ZLsdOb02n6NqwTn7MGyyWQprcCEo2Wm6Y6rStEw@mail.gmail.com>
<[email protected]>
<CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
<[email protected]>
On Fri, Jul 31, 2020 at 2:04 AM Chapman Flack <[email protected]> wrote:
> On 07/30/20 16:13, Kartik Ohri wrote:
> > I saw you had used project.build.sourceEncoding which is the default
> value
> > of inputEncoding [1]. Only if this value is null, the getInputEncoding
> > method returns ReaderFactory.FILE_ENCODING [2]. But since javadoc is not
> > complaining in the current implementation, the null case does not
> > apply. So, this will be probably redundant. A similar argument for output
> > encoding, it uses a different value which can also be interpolated
> directly
> > in the pom. Should I still expose public methods calling these ?
>
> As you say, the importance is kind of minor ... but if the effort required
> is also minor, it is probably worthwhile, just because it allows a script
> snippet to be written in a way that will look 'right' on its face to any
> casual reader, who need not know as much of the implementation detail
> as you do.
Yes, that indeed makes sense :). I have made and pushed the
required changes.
>
>
Might be simplest just to override them, loosening the access modifier
> to public and calling the super method. As 'this' is already available
> to the script, maybe nothing more is needed.
>
> Regards,
> -Chap
>
Regards,
Kartik
view thread (132+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: PL/Java new build plugin
In-Reply-To: <CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox