public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kartik Ohri <[email protected]>
To: Chapman Flack <[email protected]>
Cc: [email protected]
Subject: Re: PL/Java new build plugin
Date: Sun, 5 Jul 2020 16:14:08 +0530
Message-ID: <CAASLQ4NXzEttesB48wxD_wvR5_rNDvXZkKCmNELn247+W_vrMw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
	<[email protected]>
	<CAASLQ4P6vTfRNVnreNp7Su8VmyhA+wKOYDY8iUfa7eSoogFkXA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAASLQ4N0KeUx8PaJMKbHWiVtLvBo3QNACdHgOyk72q30976d+g@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NvfJz8VQQFU8mKkY4RabiVQesxdbkudk5Cf24Tm9BixQ@mail.gmail.com>
	<[email protected]>
	<CAASLQ4M3+XNBYiHMg32X6poY25eMbvMC5MHbA48pt30QK8nAww@mail.gmail.com>
	<[email protected]>
	<CAASLQ4PtGSS-OP9k_740EBdyT1bVmDi1PUndn1ZNWzyJDRQkMA@mail.gmail.com>
	<[email protected]>

>
> DOTALL is the long name of one of those flags (s); the other one (i) is
> CASE_INSENSITIVE. Am I missing where they are being set?

 I saw I had not committed the change. I'll fix it in the next commit.

> Oh, I think I see where that probably is. For some reason, while the
> 'replacement' string in the underlying java.util.regex methods uses
> $1, $2, etc., to refer to captured groups, just to keep things interesting
> the 'replace' attribute in an ant containsregex element uses \1, \2
> instead. I bet if you ran the output through od or the like, you would see
> that the two empty boxes are the byte values 001 and 002, which are what \1
> and \2 in a Java string literal represent.
>
 Thanks. This fixed the issue.

> Have you written out the assumptions that must be true of pg_config's
> output, for parsing it into the separate properties to be reliable?
>
 The only assumption I make is that pg_config prints each variable
separated by the system's file separator.

I have deleted the ant-run code generating the pgsql.properties file and
read the pgxs.properties file generated by PL/Java PGXS plugin. I have set
up the branch with CI and have observed that this is working for Linux and
macOS but failing for Windows. I will try to debug why this fails for
Windows.


view thread (132+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: PL/Java new build plugin
  In-Reply-To: <CAASLQ4NXzEttesB48wxD_wvR5_rNDvXZkKCmNELn247+W_vrMw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox