postgresql-interfaces/psqlodbc GitHub issues and pull requests (mirror)  
help / color / mirror / Atom feed
From: chrullrich (@chrullrich) <[email protected]>
To: postgresql-interfaces/psqlodbc <[email protected]>
Subject: Re: [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
Date: Thu, 05 Jun 2025 10:03:16 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

It doesn't. The files are passed through unmodified, so the version resources have to be correct in them. WiX extracts the version number for its own purposes, too, but the way the installers work this does not prevent it from replacing the files with the new versions.

The display form of the version number did not update because 151feaa8080181a5ae0f9bc4d2211e5bd69e5539 replaced the macro POSTGRES_RESOURCE_VERSION in psqlodbc.rc with a literal "17.00.0004" in four places.

As to why the internal versions did not change even though psqlodbc.rc includes version.h, I currently have no idea. There may be something in the build procedure that did not get updated; version.h mentions that the versions may be overridden by command line arguments from psqlodbc.vcxproj, and it looks like that file uses the arguments. I have not yet found out where it takes their values from.



view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://postgresql-interfaces/psqlodbc
  Cc: [email protected], [email protected]
  Subject: Re: [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox