public inbox for [email protected]
help / color / mirror / Atom feedFrom: Christian Ferrari <[email protected]>
To: [email protected]
Subject: Re: Feature branches merged to master for 2.8 release
Date: Sun, 28 Oct 2018 21:35:41 +0000 (UTC)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CA+mi_8aVzn-4Ujuqg5aMduHjL1XQ3Y7sUU86s3p6shMefaPoSQ@mail.gmail.com>
<[email protected]>
<CA+mi_8bSZw7CAFPOKyanYVu2_AbP-+gcUd8N7oD-oisgth6o6A@mail.gmail.com>
<[email protected]>
<[email protected]>
Dear All,today I have released LIXA 1.7.1 with Python/Psycopg2 support.To avoid two different methods (get_native_connection() for PostgreSQL and _get_native_connection() for MySQL/MariaDB) I have created a fork of Psycopg2 https://github.com/tiian/psycopg2/tree/get-native-connection with the code provided by Federico and method "get_native_connection" renamed.For the sake of convenience I have created a pull request: https://github.com/psycopg/psycopg2/pull/798 feel free to integrate it or to go on with the process you figured out in the past.Kind RegardsCh.F.
-------------------------------------------------------------
Good design can't stop bad implementation
Il domenica 21 ottobre 2018, 22:05:14 CEST, Christian Ferrari <[email protected]> ha scritto:
> Yes, I'll merge that tomorrow (no time today). I was for a name without
> the underscore but the MySQL guy has a point where he says that the
> client code should be warned that the driver can't guarantee API
> stability in this case (what if PGconn changes?). So, maybe
> `_get_native_connection()` is OK.
> federico
Dear Federico,mysqlclient-python accepted the pull requesthttps://github.com/PyMySQL/mysqlclient-python/commit/54c69436f45f2c78b3ace754780a1a265e60d430and the final method name for MySQLdb connection is "_get_native_connection()"
I'm ready to release LIXA 1.7.1 with XTA support for Python2/3 and PostgreSQL/MySQL/MariaDB, but currently I still have all the examples with"get_native_connection()" for PostgreSQLand"_get_native_connection()" for MySQL/MariaDB
Do you mind if I fork the master branch of Psycopg2 and apply your changes? I would like to avoid a release with inconsistent method name that should be fixed as soon as Psycopg2 2.8 will be available.
Kind RegardsCh.F.
view thread (20+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Feature branches merged to master for 2.8 release
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox