From: sergiyvamz (@sergiyvamz) <noreply+sergiyvamz@github.com>
To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>
Subject: Re: [aws/aws-advanced-jdbc-wrapper] PR #2237: feat: add efm3 host monitoring plugin with per-connection registration
Date: Wed, 18 Nov 2026 22:52:52 +0000
Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621968075@github.com> (raw)
In-Reply-To: <gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621672746@github.com>
References: <gh-aws-aws-advanced-jdbc-wrapper-2237@github.com>
<gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621672746@github.com>
(on wrapper/src/main/java/software/amazon/jdbc/plugin/efm/v3/HostMonitorServiceV3Impl.java)
monitorDisposalTime now lives in HostMonitoringConnectionBasePlugin (the V1/V2 service constants stay as aliases so existing references compile), and the monitoring- prefix handling moved to efm.base.HostMonitoringProperties, used by all three monitors. I kept the probes separate: efm and efm2 compute the isValid timeout differently, and efm also submits a per-node counter, so sharing that code would change efm/efm2 behaviour. Happy to do it as a follow-up.