public inbox for [email protected]help / color / mirror / Atom feed
We have no Windows critters contributing typedef lists 4+ messages / 2 participants [nested] [flat]
* We have no Windows critters contributing typedef lists @ 2018-03-06 22:25 Tom Lane <[email protected]> 2018-03-07 00:40 ` Re: We have no Windows critters contributing typedef lists Andrew Dunstan <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Tom Lane @ 2018-03-06 22:25 UTC (permalink / raw) To: [email protected] A pgindent run I just did showed me that we no longer have entries in the buildfarm's typedefs list for any typedefs that are used only in EXEC_BACKEND builds --- and, I suppose, none for Windows-only code either. I suppose that one of the recently deceased Windows animals was the only one contributing those. We need to improve this situation before it's time to run pgindent again. I'm not sure what the infrastructure requirements are for extracting typedefs from Windows builds. regards, tom lane ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: We have no Windows critters contributing typedef lists 2018-03-06 22:25 We have no Windows critters contributing typedef lists Tom Lane <[email protected]> @ 2018-03-07 00:40 ` Andrew Dunstan <[email protected]> 2018-03-07 04:27 ` Re: We have no Windows critters contributing typedef lists Tom Lane <[email protected]> 2018-03-07 04:46 ` Re: We have no Windows critters contributing typedef lists Andrew Dunstan <[email protected]> 0 siblings, 2 replies; 4+ messages in thread From: Andrew Dunstan @ 2018-03-07 00:40 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: [email protected] On Wed, Mar 7, 2018 at 8:55 AM, Tom Lane <[email protected]> wrote: > A pgindent run I just did showed me that we no longer have entries in > the buildfarm's typedefs list for any typedefs that are used only in > EXEC_BACKEND builds --- and, I suppose, none for Windows-only code > either. I suppose that one of the recently deceased Windows animals > was the only one contributing those. We need to improve this situation > before it's time to run pgindent again. > > I'm not sure what the infrastructure requirements are for extracting > typedefs from Windows builds. > Nothing special I think. I have just enabled it for jacana and also for bowerbird which I am reviving. Basically it's just a matter of adding find_typedefs => {}, to the optional_steps part of the config file. That will make it get the typedefs for every build of every branch. You should see some results in a few hours. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: We have no Windows critters contributing typedef lists 2018-03-06 22:25 We have no Windows critters contributing typedef lists Tom Lane <[email protected]> 2018-03-07 00:40 ` Re: We have no Windows critters contributing typedef lists Andrew Dunstan <[email protected]> @ 2018-03-07 04:27 ` Tom Lane <[email protected]> 1 sibling, 0 replies; 4+ messages in thread From: Tom Lane @ 2018-03-07 04:27 UTC (permalink / raw) To: Andrew Dunstan <[email protected]>; +Cc: [email protected] Andrew Dunstan <[email protected]> writes: > On Wed, Mar 7, 2018 at 8:55 AM, Tom Lane <[email protected]> wrote: >> I'm not sure what the infrastructure requirements are for extracting >> typedefs from Windows builds. > Nothing special I think. I have just enabled it for jacana and also > for bowerbird which I am reviving. Thanks! regards, tom lane ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: We have no Windows critters contributing typedef lists 2018-03-06 22:25 We have no Windows critters contributing typedef lists Tom Lane <[email protected]> 2018-03-07 00:40 ` Re: We have no Windows critters contributing typedef lists Andrew Dunstan <[email protected]> @ 2018-03-07 04:46 ` Andrew Dunstan <[email protected]> 1 sibling, 0 replies; 4+ messages in thread From: Andrew Dunstan @ 2018-03-07 04:46 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: [email protected] On Wed, Mar 7, 2018 at 11:10 AM, Andrew Dunstan <[email protected]> wrote: > On Wed, Mar 7, 2018 at 8:55 AM, Tom Lane <[email protected]> wrote: >> A pgindent run I just did showed me that we no longer have entries in >> the buildfarm's typedefs list for any typedefs that are used only in >> EXEC_BACKEND builds --- and, I suppose, none for Windows-only code >> either. I suppose that one of the recently deceased Windows animals >> was the only one contributing those. We need to improve this situation >> before it's time to run pgindent again. >> >> I'm not sure what the infrastructure requirements are for extracting >> typedefs from Windows builds. >> > > > Nothing special I think. I have just enabled it for jacana and also > for bowerbird which I am reviving. Basically it's just a matter of > adding > find_typedefs => {}, > to the optional_steps part of the config file. That will make it get > the typedefs for every build of every branch. > > You should see some results in a few hours. > Or not. There is a strange error I will need to get to the bottom of. Might be a day or two. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2018-03-07 04:46 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2018-03-06 22:25 We have no Windows critters contributing typedef lists Tom Lane <[email protected]> 2018-03-07 00:40 ` Andrew Dunstan <[email protected]> 2018-03-07 04:27 ` Tom Lane <[email protected]> 2018-03-07 04:46 ` Andrew Dunstan <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox