public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 1/2] Fix link to code_review in submitting_patches.rst
4+ messages / 2 participants
[nested] [flat]
* [PATCH 1/2] Fix link to code_review in submitting_patches.rst
@ 2016-10-09 12:27 Chris Mayo <[email protected]>
0 siblings, 2 replies; 4+ messages in thread
From: Chris Mayo @ 2016-10-09 12:27 UTC (permalink / raw)
To: pgadmin-hackers
Signed-off-by: Chris Mayo <[email protected]>
---
docs/en_US/submitting_patches.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_patches.rst
index b4bbebe..9f8ab42 100644
--- a/docs/en_US/submitting_patches.rst
+++ b/docs/en_US/submitting_patches.rst
@@ -29,7 +29,7 @@ might run::
to create a patch between your development branch and the public master branch.
Once you have your patch, check it thoroughly to ensure it meets the pgAdmin
-:doc:`coding_standards`, and review it against the :doc:`code-review' to minimise
+:doc:`coding_standards`, and review it against the :doc:`code_review` to minimise
the chances of it being rejected. Once you're happy with your work, mail it to the
`mailing list <mailto:[email protected]>`. Please ensure you
include a full description of what the patch does, as well as the rationale for
--
2.7.3
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH 2/2] Improve references to the mailing list in docs
@ 2016-10-09 12:27 Chris Mayo <[email protected]>
parent: Chris Mayo <[email protected]>
1 sibling, 1 reply; 4+ messages in thread
From: Chris Mayo @ 2016-10-09 12:27 UTC (permalink / raw)
To: pgadmin-hackers
Just let Sphinx discover the email address; displays better in
browser and pgAdmin4 runtime.
Signed-off-by: Chris Mayo <[email protected]>
---
docs/en_US/contributions.rst | 2 +-
docs/en_US/submitting_patches.rst | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/en_US/contributions.rst b/docs/en_US/contributions.rst
index a395e12..7cd3026 100644
--- a/docs/en_US/contributions.rst
+++ b/docs/en_US/contributions.rst
@@ -4,7 +4,7 @@
pgAdmin Project Contributions
*****************************
-pgAdmin is an open-source project that invites you to get involved in the development process. For more information about contributing to the pgAdmin project, contact the developers on the pgAdmin mailing list <mailto:[email protected]> to discuss any ideas you might have for enhancements or bug fixes.
+pgAdmin is an open-source project that invites you to get involved in the development process. For more information about contributing to the pgAdmin project, contact the developers on the pgAdmin mailing list [email protected] to discuss any ideas you might have for enhancements or bug fixes.
In the sections listed below, you'll find detailed information about the development process used to develop, improve, and maintain the pgAdmin client.
diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_patches.rst
index 9f8ab42..a3ced06 100644
--- a/docs/en_US/submitting_patches.rst
+++ b/docs/en_US/submitting_patches.rst
@@ -5,7 +5,7 @@ Submitting Patches
******************
Before developing a patch for pgAdmin you should always contact the developers
-on the `mailing list <mailto:[email protected]>` to discuss your
+on the mailing list [email protected] to discuss your
plans. This ensures that others know if you're fixing a bug and can then avoid
duplicating your work, and in the case of large patches, gives the community
the chance to discuss and refine your ideas before investing too much time
@@ -31,6 +31,6 @@ to create a patch between your development branch and the public master branch.
Once you have your patch, check it thoroughly to ensure it meets the pgAdmin
:doc:`coding_standards`, and review it against the :doc:`code_review` to minimise
the chances of it being rejected. Once you're happy with your work, mail it to the
-`mailing list <mailto:[email protected]>`. Please ensure you
+mailing list [email protected]. Please ensure you
include a full description of what the patch does, as well as the rationale for
any important design decisions.
\ No newline at end of file
--
2.7.3
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [PATCH 1/2] Fix link to code_review in submitting_patches.rst
@ 2016-10-10 08:33 Dave Page <[email protected]>
parent: Chris Mayo <[email protected]>
1 sibling, 0 replies; 4+ messages in thread
From: Dave Page @ 2016-10-10 08:33 UTC (permalink / raw)
To: Chris Mayo <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
BTW, please send any future patches as attachments rather than inline, as I
had to apply this manually as it got munged in the email body.
Thanks!
On Sunday, October 9, 2016, Chris Mayo <[email protected]> wrote:
> Signed-off-by: Chris Mayo <[email protected] <javascript:;>>
> ---
> docs/en_US/submitting_patches.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_
> patches.rst
> index b4bbebe..9f8ab42 100644
> --- a/docs/en_US/submitting_patches.rst
> +++ b/docs/en_US/submitting_patches.rst
> @@ -29,7 +29,7 @@ might run::
> to create a patch between your development branch and the public master
> branch.
>
> Once you have your patch, check it thoroughly to ensure it meets the
> pgAdmin
> -:doc:`coding_standards`, and review it against the :doc:`code-review' to
> minimise
> +:doc:`coding_standards`, and review it against the :doc:`code_review` to
> minimise
> the chances of it being rejected. Once you're happy with your work, mail
> it to the
> `mailing list <mailto:[email protected] <javascript:;>>`.
> Please ensure you
> include a full description of what the patch does, as well as the
> rationale for
> --
> 2.7.3
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected]
> <javascript:;>)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [PATCH 2/2] Improve references to the mailing list in docs
@ 2016-10-10 08:33 Dave Page <[email protected]>
parent: Chris Mayo <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Dave Page @ 2016-10-10 08:33 UTC (permalink / raw)
To: Chris Mayo <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
BTW, please send any future patches as attachments rather than inline, as I
had to apply this manually as it got munged in the email body.
Thanks!
On Sunday, October 9, 2016, Chris Mayo <[email protected]> wrote:
> Just let Sphinx discover the email address; displays better in
> browser and pgAdmin4 runtime.
>
> Signed-off-by: Chris Mayo <[email protected] <javascript:;>>
> ---
> docs/en_US/contributions.rst | 2 +-
> docs/en_US/submitting_patches.rst | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/en_US/contributions.rst b/docs/en_US/contributions.rst
> index a395e12..7cd3026 100644
> --- a/docs/en_US/contributions.rst
> +++ b/docs/en_US/contributions.rst
> @@ -4,7 +4,7 @@
> pgAdmin Project Contributions
> *****************************
>
> -pgAdmin is an open-source project that invites you to get involved in the
> development process. For more information about contributing to the
> pgAdmin project, contact the developers on the pgAdmin mailing list <mailto:
> [email protected] <javascript:;>> to discuss any ideas you
> might have for enhancements or bug fixes.
> +pgAdmin is an open-source project that invites you to get involved in the
> development process. For more information about contributing to the
> pgAdmin project, contact the developers on the pgAdmin mailing list
> [email protected] <javascript:;> to discuss any ideas you
> might have for enhancements or bug fixes.
>
> In the sections listed below, you'll find detailed information about the
> development process used to develop, improve, and maintain the pgAdmin
> client.
>
> diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_
> patches.rst
> index 9f8ab42..a3ced06 100644
> --- a/docs/en_US/submitting_patches.rst
> +++ b/docs/en_US/submitting_patches.rst
> @@ -5,7 +5,7 @@ Submitting Patches
> ******************
>
> Before developing a patch for pgAdmin you should always contact the
> developers
> -on the `mailing list <mailto:[email protected]
> <javascript:;>>` to discuss your
> +on the mailing list [email protected] <javascript:;> to
> discuss your
> plans. This ensures that others know if you're fixing a bug and can then
> avoid
> duplicating your work, and in the case of large patches, gives the
> community
> the chance to discuss and refine your ideas before investing too much time
> @@ -31,6 +31,6 @@ to create a patch between your development branch and
> the public master branch.
> Once you have your patch, check it thoroughly to ensure it meets the
> pgAdmin
> :doc:`coding_standards`, and review it against the :doc:`code_review` to
> minimise
> the chances of it being rejected. Once you're happy with your work, mail
> it to the
> -`mailing list <mailto:[email protected] <javascript:;>>`.
> Please ensure you
> +mailing list [email protected] <javascript:;>. Please
> ensure you
> include a full description of what the patch does, as well as the
> rationale for
> any important design decisions.
> \ No newline at end of file
> --
> 2.7.3
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected]
> <javascript:;>)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2016-10-10 08:33 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-10-09 12:27 [PATCH 1/2] Fix link to code_review in submitting_patches.rst Chris Mayo <[email protected]>
2016-10-09 12:27 ` [PATCH 2/2] Improve references to the mailing list in docs Chris Mayo <[email protected]>
2016-10-10 08:33 ` Re: [PATCH 2/2] Improve references to the mailing list in docs Dave Page <[email protected]>
2016-10-10 08:33 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox