public inbox for [email protected]help / color / mirror / Atom feed
Is there a mistake in line 22 of Make.bat? 3+ messages / 2 participants [nested] [flat]
* Is there a mistake in line 22 of Make.bat? @ 2021-01-14 01:20 Huang, Jun <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Huang, Jun @ 2021-01-14 01:20 UTC (permalink / raw) To: pgadmin-hackers Hi, The following code is line 22 of Make.bat: if "%Platform%" == "X86" ( I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the result is "x86"(not "X86"). If it's a mistake, the attached patch adds the changes. Regrads, Huang Attachments: [application/octet-stream] Fix-Platfrom.patch (262B, 2-Fix-Platfrom.patch) download | inline diff: diff --git a/Make.bat b/Make.bat index 11a755ffe..ac0be6339 100644 --- a/Make.bat +++ b/Make.bat @@ -19,7 +19,7 @@ IF "%1" == "clean" ( ) set "ARCHITECTURE=x64" -if "%Platform%" == "X86" ( +if "%Platform%" == "x86" ( set "ARCHITECTURE=x86" ) ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Is there a mistake in line 22 of Make.bat? @ 2021-01-14 09:14 Dave Page <[email protected]> parent: Huang, Jun <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Dave Page @ 2021-01-14 09:14 UTC (permalink / raw) To: Huang, Jun <[email protected]>; +Cc: pgadmin-hackers Hi On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun <[email protected]> wrote: > Hi, > > The following code is line 22 of Make.bat: > if "%Platform%" == "X86" ( > > I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the > result is "x86"(not "X86"). > If it's a mistake, the attached patch adds the changes. > Hmm, on the 32bit build VM I get this: C:\Program Files (x86)\Microsoft Visual C++ Build Tools>echo %Platform% X86 C:\Program Files (x86)\Microsoft Visual C++ Build Tools> Which explains why everything works in the production builds. Note that that system is VS 2015 though, but the 64 bit builds are VS 2017 iirc. Given that 32 bit Windows builds will be dropped soon, I'm inclined to leave this as-is for now. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 3+ messages in thread
* RE: Is there a mistake in line 22 of Make.bat? @ 2021-01-15 00:44 Huang, Jun <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Huang, Jun @ 2021-01-15 00:44 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Thanks for your answer. -- Thanks & Regards HuangJ From: Dave Page <[email protected]> Sent: Thursday, January 14, 2021 5:15 PM To: Huang, Jun/黄 军 <[email protected]> Cc: [email protected] Subject: Re: Is there a mistake in line 22 of Make.bat? Hi On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun <[email protected]<mailto:[email protected]>> wrote: Hi, The following code is line 22 of Make.bat: if "%Platform%" == "X86" ( I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the result is "x86"(not "X86"). If it's a mistake, the attached patch adds the changes. Hmm, on the 32bit build VM I get this: C:\Program Files (x86)\Microsoft Visual C++ Build Tools>echo %Platform% X86 C:\Program Files (x86)\Microsoft Visual C++ Build Tools> Which explains why everything works in the production builds. Note that that system is VS 2015 though, but the 64 bit builds are VS 2017 iirc. Given that 32 bit Windows builds will be dropped soon, I'm inclined to leave this as-is for now. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-01-15 00:44 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-01-14 01:20 Is there a mistake in line 22 of Make.bat? Huang, Jun <[email protected]> 2021-01-14 09:14 ` Dave Page <[email protected]> 2021-01-15 00:44 ` Huang, Jun <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox