public inbox for [email protected]
help / color / mirror / Atom feedStyling SQL box layout on dialogue
9+ messages / 2 participants
[nested] [flat]
* Styling SQL box layout on dialogue
@ 2016-04-07 14:35 Arun Kollan <[email protected]>
2016-04-07 14:53 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Arun Kollan @ 2016-04-07 14:35 UTC (permalink / raw)
To: pgadmin-hackers; Dave Page <[email protected]>
Hi Team,
please find attached css styling changes for SQL box layout on dialogue boxes. The SQL box fills the entire control space with no margin for the gutter.
Regards,
Arun Kollan
Website: www.enterprisedb.com <http://www.enterprisedb.com/;
EnterpriseDB Blog: http://blogs.enterprisedb.com/ <http://blogs.enterprisedb.com/;
Follow us on Twitter: http://www.twitter.com/enterprisedb <http://www.twitter.com/enterprisedb;
This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
Attachments:
[application/zip] sql-box-layout-styling.patch.zip (1.0K, 3-sql-box-layout-styling.patch.zip)
download
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Styling SQL box layout on dialogue
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
@ 2016-04-07 14:53 ` Dave Page <[email protected]>
2016-04-08 13:23 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2016-04-07 14:53 UTC (permalink / raw)
To: Arun Kollan <[email protected]>; +Cc: pgadmin-hackers
On Thu, Apr 7, 2016 at 3:35 PM, Arun Kollan
<[email protected]> wrote:
> Hi Team,
> please find attached css styling changes for SQL box layout on dialogue
> boxes. The SQL box fills the entire control space with no margin for the
> gutter.
Per office discussion, this breaks the vertical sizing in the
browser's SQL tab. Arun to re-work.
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Styling SQL box layout on dialogue
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-07 14:53 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
@ 2016-04-08 13:23 ` Arun Kollan <[email protected]>
2016-04-11 09:09 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Arun Kollan @ 2016-04-08 13:23 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Team,
please find attached the patch for styling the sql editor on a dialogue
window. The separate rule has been written to include the style specific
to a control window.
Regards,
Arun Kollan
On Thu, Apr 7, 2016 at 3:53 PM, Dave Page <[email protected]>
wrote:
> On Thu, Apr 7, 2016 at 3:35 PM, Arun Kollan
> <[email protected]> wrote:
> > Hi Team,
> > please find attached css styling changes for SQL box layout on dialogue
> > boxes. The SQL box fills the entire control space with no margin for the
> > gutter.
>
> Per office discussion, this breaks the vertical sizing in the
> browser's SQL tab. Arun to re-work.
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/zip] sql-box-layout-styling.patch.zip (1.0K, 3-sql-box-layout-styling.patch.zip)
download
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Styling SQL box layout on dialogue
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-07 14:53 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-08 13:23 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
@ 2016-04-11 09:09 ` Dave Page <[email protected]>
2016-04-11 09:45 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2016-04-11 09:09 UTC (permalink / raw)
To: Arun Kollan <[email protected]>; +Cc: pgadmin-hackers
On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan
<[email protected]> wrote:
> Hi Team,
>
> please find attached the patch for styling the sql editor on a dialogue
> window. The separate rule has been written to include the style specific to
> a control window.
There still seem to be padding/margin issues on my machine (under
Chrome). Am I missing something?
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[image/png] Screen Shot 2016-04-11 at 10.07.08.png (107.6K, 2-Screen%20Shot%202016-04-11%20at%2010.07.08.png)
download | view image
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Styling SQL box layout on dialogue
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-07 14:53 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-08 13:23 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 09:09 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
@ 2016-04-11 09:45 ` Arun Kollan <[email protected]>
2016-04-11 10:31 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Arun Kollan @ 2016-04-11 09:45 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
Looks the like the patch is out of sync with the repository. I will create another patch now.
Regards,
Arun Kollan
Website: www.enterprisedb.com <http://www.enterprisedb.com/;
EnterpriseDB Blog: http://blogs.enterprisedb.com/ <http://blogs.enterprisedb.com/;
Follow us on Twitter: http://www.twitter.com/enterprisedb <http://www.twitter.com/enterprisedb;
This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
> On 11 Apr 2016, at 10:09, Dave Page <[email protected]> wrote:
>
> On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan
> <[email protected]> wrote:
>> Hi Team,
>>
>> please find attached the patch for styling the sql editor on a dialogue
>> window. The separate rule has been written to include the style specific to
>> a control window.
>
> There still seem to be padding/margin issues on my machine (under
> Chrome). Am I missing something?
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
> <Screen Shot 2016-04-11 at 10.07.08.png>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Styling SQL box layout on dialogue
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-07 14:53 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-08 13:23 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 09:09 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-11 09:45 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
@ 2016-04-11 10:31 ` Arun Kollan <[email protected]>
2016-04-11 12:33 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Arun Kollan @ 2016-04-11 10:31 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
Please find attached the zipped version of the patch. I have tested it against the latest version from the repository. I had quick look comparing the patches and it looks to contain the same rules.
Regards,
Arun Kollan
Website: www.enterprisedb.com <http://www.enterprisedb.com/;
EnterpriseDB Blog: http://blogs.enterprisedb.com/ <http://blogs.enterprisedb.com/;
Follow us on Twitter: http://www.twitter.com/enterprisedb <http://www.twitter.com/enterprisedb;
This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
> On 11 Apr 2016, at 10:45, Arun Kollan <[email protected]> wrote:
>
> Hi Dave,
> Looks the like the patch is out of sync with the repository. I will create another patch now.
>
> Regards,
> Arun Kollan
> Website: www.enterprisedb.com <http://www.enterprisedb.com/;
> EnterpriseDB Blog: http://blogs.enterprisedb.com/ <http://blogs.enterprisedb.com/;
> Follow us on Twitter: http://www.twitter.com/enterprisedb <http://www.twitter.com/enterprisedb;
>
> This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
>
>
>
>
>> On 11 Apr 2016, at 10:09, Dave Page <[email protected] <mailto:[email protected]>> wrote:
>>
>> On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan
>> <[email protected] <mailto:[email protected]>> wrote:
>>> Hi Team,
>>>
>>> please find attached the patch for styling the sql editor on a dialogue
>>> window. The separate rule has been written to include the style specific to
>>> a control window.
>>
>> There still seem to be padding/margin issues on my machine (under
>> Chrome). Am I missing something?
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/;
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com <http://pgsnake.blogspot.com/;
>> Twitter: @pgsnake
>> <Screen Shot 2016-04-11 at 10.07.08.png>
>
Attachments:
[application/octet-stream] sql-box-layout-stylingv2.patch (2.0K, 3-sql-box-layout-stylingv2.patch)
download | inline diff:
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 16f7f0a..16ea37a 100755
--- a/web/pgadmin/static/css/overrides.css
+++ b/web/pgadmin/static/css/overrides.css
@@ -276,6 +276,11 @@ iframe {
padding-right: 3px;
padding-left: 3px;
}
+.pgadmin-controls.SQL {
+ min-width: 290px;
+ padding-right: 3px;
+ padding-left: 1px;
+}
.pgadmin-controls > textarea.form-control,
.pgadmin-controls > textarea.form-control[disabled] {
min-width: 100%;
@@ -855,11 +860,20 @@ td.edit-cell.editable.sortable.renderable.editor {
}
.sql_field_height_300 {
- height: 300px;
+ height: 340px;
}
.sql_field_height_400 {
- height: 400px;
+ height: 440px;
+}
+
+.tab-pane.SQL {
+ padding: 0px 7px 0px 0px;
+}
+
+.pgadmin-control-group.sql {
+ margin: 0px;
+ padding: 0px;
}
.nav-tabs{
@@ -929,3 +943,7 @@ ul.nav.nav-tabs {
.pgadmin-control-group span.wcTabIcon {
padding-left: 20px;
}
+
+.pgadmin-controls.SQL>.CodeMirror {
+ height: 500px!important;
+}
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 8eaed6d..0f7edc8 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -519,7 +519,7 @@
' id="<%=hId%>" aria-controls="<%=cId%>">',
'<%=label%></a></li>'].join(" ")),
'panel': _.template(
- '<div role="tabpanel" class="tab-pane col-sm-12 col-md-12 col-lg-12 col-xs-12 fade" id="<%=cId%>" aria-labelledby="<%=hId%>"></div>'
+ '<div role="tabpanel" class="tab-pane <%=label%> col-sm-12 col-md-12 col-lg-12 col-xs-12 fade" id="<%=cId%>" aria-labelledby="<%=hId%>"></div>'
)},
render: function() {
this.cleanup();
@@ -1307,7 +1307,7 @@
var SqlTabControl = Backform.SqlTabControl = Backform.Control.extend({
defaults: {
label: "",
- controlsClassName: "pgadmin-controls col-sm-12",
+ controlsClassName: "pgadmin-controls col-sm-12 SQL",
extraClasses: [],
helpMessage: null
},
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Styling SQL box layout on dialogue
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-07 14:53 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-08 13:23 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 09:09 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-11 09:45 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 10:31 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
@ 2016-04-11 12:33 ` Dave Page <[email protected]>
2016-04-11 12:59 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2016-04-11 12:33 UTC (permalink / raw)
To: Arun Kollan <[email protected]>; +Cc: pgadmin-hackers
Still looks the same as my last screenshot to me.
On Mon, Apr 11, 2016 at 11:31 AM, Arun Kollan
<[email protected]> wrote:
> Hi Dave,
> Please find attached the zipped version of the patch. I have tested it
> against the latest version from the repository. I had quick look comparing
> the patches and it looks to contain the same rules.
>
>
> Regards,
>
> Arun Kollan
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of the
> individual or entity to whom it is addressed. This message contains
> information from EnterpriseDB Corporation that may be privileged,
> confidential, or exempt from disclosure under applicable law. If you are not
> the intended recipient or authorized to receive this for the intended
> recipient, any use, dissemination, distribution, retention, archiving, or
> copying of this communication is strictly prohibited. If you have received
> this e-mail in error, please notify the sender immediately by reply e-mail
> and delete this message.
>
>
>
>
> On 11 Apr 2016, at 10:45, Arun Kollan <[email protected]> wrote:
>
> Hi Dave,
> Looks the like the patch is out of sync with the repository. I will create
> another patch now.
>
> Regards,
> Arun Kollan
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of the
> individual or entity to whom it is addressed. This message contains
> information from EnterpriseDB Corporation that may be privileged,
> confidential, or exempt from disclosure under applicable law. If you are not
> the intended recipient or authorized to receive this for the intended
> recipient, any use, dissemination, distribution, retention, archiving, or
> copying of this communication is strictly prohibited. If you have received
> this e-mail in error, please notify the sender immediately by reply e-mail
> and delete this message.
>
>
>
>
> On 11 Apr 2016, at 10:09, Dave Page <[email protected]> wrote:
>
> On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan
> <[email protected]> wrote:
>
> Hi Team,
>
> please find attached the patch for styling the sql editor on a dialogue
> window. The separate rule has been written to include the style specific to
> a control window.
>
>
> There still seem to be padding/margin issues on my machine (under
> Chrome). Am I missing something?
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
> <Screen Shot 2016-04-11 at 10.07.08.png>
>
>
>
>
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Styling SQL box layout on dialogue
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-07 14:53 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-08 13:23 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 09:09 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-11 09:45 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 10:31 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 12:33 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
@ 2016-04-11 12:59 ` Arun Kollan <[email protected]>
2016-04-12 15:55 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Arun Kollan @ 2016-04-11 12:59 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
I asked Murtuza to apply the patch at his end and test on Chrome and Firefox. We had a Skype session and it does appear to fix the issue. It required a hard reload and cache clearing to get it working.
I am assuming that the screenshot displayed is the dialogue window for database properties.
Regards,
Arun Kollan
Website: www.enterprisedb.com <http://www.enterprisedb.com/;
EnterpriseDB Blog: http://blogs.enterprisedb.com/ <http://blogs.enterprisedb.com/;
Follow us on Twitter: http://www.twitter.com/enterprisedb <http://www.twitter.com/enterprisedb;
This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
> On 11 Apr 2016, at 13:33, Dave Page <[email protected]> wrote:
>
> Still looks the same as my last screenshot to me.
>
> On Mon, Apr 11, 2016 at 11:31 AM, Arun Kollan
> <[email protected]> wrote:
>> Hi Dave,
>> Please find attached the zipped version of the patch. I have tested it
>> against the latest version from the repository. I had quick look comparing
>> the patches and it looks to contain the same rules.
>>
>>
>> Regards,
>>
>> Arun Kollan
>> Website: www.enterprisedb.com
>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>
>> This e-mail message (and any attachment) is intended for the use of the
>> individual or entity to whom it is addressed. This message contains
>> information from EnterpriseDB Corporation that may be privileged,
>> confidential, or exempt from disclosure under applicable law. If you are not
>> the intended recipient or authorized to receive this for the intended
>> recipient, any use, dissemination, distribution, retention, archiving, or
>> copying of this communication is strictly prohibited. If you have received
>> this e-mail in error, please notify the sender immediately by reply e-mail
>> and delete this message.
>>
>>
>>
>>
>> On 11 Apr 2016, at 10:45, Arun Kollan <[email protected]> wrote:
>>
>> Hi Dave,
>> Looks the like the patch is out of sync with the repository. I will create
>> another patch now.
>>
>> Regards,
>> Arun Kollan
>> Website: www.enterprisedb.com
>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>
>> This e-mail message (and any attachment) is intended for the use of the
>> individual or entity to whom it is addressed. This message contains
>> information from EnterpriseDB Corporation that may be privileged,
>> confidential, or exempt from disclosure under applicable law. If you are not
>> the intended recipient or authorized to receive this for the intended
>> recipient, any use, dissemination, distribution, retention, archiving, or
>> copying of this communication is strictly prohibited. If you have received
>> this e-mail in error, please notify the sender immediately by reply e-mail
>> and delete this message.
>>
>>
>>
>>
>> On 11 Apr 2016, at 10:09, Dave Page <[email protected]> wrote:
>>
>> On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan
>> <[email protected]> wrote:
>>
>> Hi Team,
>>
>> please find attached the patch for styling the sql editor on a dialogue
>> window. The separate rule has been written to include the style specific to
>> a control window.
>>
>>
>> There still seem to be padding/margin issues on my machine (under
>> Chrome). Am I missing something?
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>> <Screen Shot 2016-04-11 at 10.07.08.png>
>>
>>
>>
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Styling SQL box layout on dialogue
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-07 14:53 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-08 13:23 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 09:09 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-11 09:45 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 10:31 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-11 12:33 ` Re: Styling SQL box layout on dialogue Dave Page <[email protected]>
2016-04-11 12:59 ` Re: Styling SQL box layout on dialogue Arun Kollan <[email protected]>
@ 2016-04-12 15:55 ` Dave Page <[email protected]>
0 siblings, 0 replies; 9+ messages in thread
From: Dave Page @ 2016-04-12 15:55 UTC (permalink / raw)
To: Arun Kollan <[email protected]>; +Cc: pgadmin-hackers
OK, taking another look it seems like it's bit-rotted. Can you rebase please?
Thanks.
piranha:web dpage$ git pull
Already up-to-date.
piranha:web dpage$ git apply ~/Downloads/sql-box-layout-stylingv2.patch
/Users/dpage/Downloads/sql-box-layout-stylingv2.patch:9: trailing whitespace.
.pgadmin-controls.SQL {
/Users/dpage/Downloads/sql-box-layout-stylingv2.patch:10: trailing whitespace.
min-width: 290px;
/Users/dpage/Downloads/sql-box-layout-stylingv2.patch:11: trailing whitespace.
padding-right: 3px;
/Users/dpage/Downloads/sql-box-layout-stylingv2.patch:12: trailing whitespace.
padding-left: 1px;
/Users/dpage/Downloads/sql-box-layout-stylingv2.patch:13: trailing whitespace.
}
error: patch failed: web/pgadmin/static/css/overrides.css:276
error: web/pgadmin/static/css/overrides.css: patch does not apply
error: patch failed: web/pgadmin/static/js/backform.pgadmin.js:519
error: web/pgadmin/static/js/backform.pgadmin.js: patch does not apply
On Mon, Apr 11, 2016 at 1:59 PM, Arun Kollan
<[email protected]> wrote:
> Hi Dave,
> I asked Murtuza to apply the patch at his end and test on Chrome and
> Firefox. We had a Skype session and it does appear to fix the issue. It
> required a hard reload and cache clearing to get it working.
>
> I am assuming that the screenshot displayed is the dialogue window for
> database properties.
>
> Regards,
> Arun Kollan
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of the
> individual or entity to whom it is addressed. This message contains
> information from EnterpriseDB Corporation that may be privileged,
> confidential, or exempt from disclosure under applicable law. If you are not
> the intended recipient or authorized to receive this for the intended
> recipient, any use, dissemination, distribution, retention, archiving, or
> copying of this communication is strictly prohibited. If you have received
> this e-mail in error, please notify the sender immediately by reply e-mail
> and delete this message.
>
>
>
>
> On 11 Apr 2016, at 13:33, Dave Page <[email protected]> wrote:
>
> Still looks the same as my last screenshot to me.
>
> On Mon, Apr 11, 2016 at 11:31 AM, Arun Kollan
> <[email protected]> wrote:
>
> Hi Dave,
> Please find attached the zipped version of the patch. I have tested it
> against the latest version from the repository. I had quick look comparing
> the patches and it looks to contain the same rules.
>
>
> Regards,
>
> Arun Kollan
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of the
> individual or entity to whom it is addressed. This message contains
> information from EnterpriseDB Corporation that may be privileged,
> confidential, or exempt from disclosure under applicable law. If you are not
> the intended recipient or authorized to receive this for the intended
> recipient, any use, dissemination, distribution, retention, archiving, or
> copying of this communication is strictly prohibited. If you have received
> this e-mail in error, please notify the sender immediately by reply e-mail
> and delete this message.
>
>
>
>
> On 11 Apr 2016, at 10:45, Arun Kollan <[email protected]> wrote:
>
> Hi Dave,
> Looks the like the patch is out of sync with the repository. I will create
> another patch now.
>
> Regards,
> Arun Kollan
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of the
> individual or entity to whom it is addressed. This message contains
> information from EnterpriseDB Corporation that may be privileged,
> confidential, or exempt from disclosure under applicable law. If you are not
> the intended recipient or authorized to receive this for the intended
> recipient, any use, dissemination, distribution, retention, archiving, or
> copying of this communication is strictly prohibited. If you have received
> this e-mail in error, please notify the sender immediately by reply e-mail
> and delete this message.
>
>
>
>
> On 11 Apr 2016, at 10:09, Dave Page <[email protected]> wrote:
>
> On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan
> <[email protected]> wrote:
>
> Hi Team,
>
> please find attached the patch for styling the sql editor on a dialogue
> window. The separate rule has been written to include the style specific to
> a control window.
>
>
> There still seem to be padding/margin issues on my machine (under
> Chrome). Am I missing something?
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
> <Screen Shot 2016-04-11 at 10.07.08.png>
>
>
>
>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
>
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2016-04-12 15:55 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-04-07 14:35 Styling SQL box layout on dialogue Arun Kollan <[email protected]>
2016-04-07 14:53 ` Dave Page <[email protected]>
2016-04-08 13:23 ` Arun Kollan <[email protected]>
2016-04-11 09:09 ` Dave Page <[email protected]>
2016-04-11 09:45 ` Arun Kollan <[email protected]>
2016-04-11 10:31 ` Arun Kollan <[email protected]>
2016-04-11 12:33 ` Dave Page <[email protected]>
2016-04-11 12:59 ` Arun Kollan <[email protected]>
2016-04-12 15:55 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox