public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][Patch]: RM1690 - Trailing spaces included in SELECT Script for functions
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][Patch]: RM1690 - Trailing spaces included in SELECT Script for functions
@ 2016-09-13 13:41 Surinder Kumar <[email protected]>
2016-09-14 10:08 ` Re: [pgAdmin4][Patch]: RM1690 - Trailing spaces included in SELECT Script for functions Dave Page <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Surinder Kumar @ 2016-09-13 13:41 UTC (permalink / raw)
To: pgadmin-hackers
Hi
Trailing spaces included in SELECT Script due to *Indentation issue*.
Please find attached patch.
Thanks,
Surinder Kumar
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] RM1690.patch (1.2K, 3-RM1690.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
index f269dcb..6fcfd64 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
@@ -1320,7 +1320,7 @@ It may have been removed by another user or moved to another schema.
"""
# Fetch the function definition.
SQL = render_template("/".join([self.sql_template_path,
- 'get_definition.sql']), fnid=fnid, scid=scid)
+ 'get_definition.sql']), fnid=fnid, scid=scid)
status, res = self.conn.execute_2darray(SQL)
if not status:
return internal_server_error(errormsg=res)
@@ -1338,7 +1338,7 @@ It may have been removed by another user or moved to another schema.
for arg in list(set(args)):
formatted_arg = '\n\t<' + arg + '>'
name = name.replace(arg, formatted_arg)
- name = name.replace(')', '\n)')
+ name = name.replace(')', '\n)')
sql = "SELECT {0}".format(name)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][Patch]: RM1690 - Trailing spaces included in SELECT Script for functions
2016-09-13 13:41 [pgAdmin4][Patch]: RM1690 - Trailing spaces included in SELECT Script for functions Surinder Kumar <[email protected]>
@ 2016-09-14 10:08 ` Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-09-14 10:08 UTC (permalink / raw)
To: Surinder Kumar <[email protected]>; +Cc: pgadmin-hackers
Thanks - applied.
On Tue, Sep 13, 2016 at 2:41 PM, Surinder Kumar
<[email protected]> wrote:
> Hi
>
> Trailing spaces included in SELECT Script due to Indentation issue.
> Please find attached patch.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-09-14 10:08 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 13:41 [pgAdmin4][Patch]: RM1690 - Trailing spaces included in SELECT Script for functions Surinder Kumar <[email protected]>
2016-09-14 10:08 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox