public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Harshal Dhumal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [PATCH] Tables node (pgAdmin4)
Date: Fri, 20 May 2016 14:31:52 -0400
Message-ID: <CA+OCxowB=LJKts18wKx982gF4ZNJnOamND0xZEMp0CnTrjeruA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcJ-Qum-BJXtDx52ij72EJVzLE+XYFE+_skJF4fXVJ9jA@mail.gmail.com>
References: <CAKKotZRCf07F_SGHi4KawBtLHPSeKz5Uvzwu6ddQ=bKc1FDRRw@mail.gmail.com>
<CAFiP3vw61T0n--F4vYXALdtrkBKznBegBPq5Ds=6uZrg02vWXQ@mail.gmail.com>
<CAFOhELea6nCtX_T78o_3mNKJC0_emirXKGm3nq8d6mvSZV57pg@mail.gmail.com>
<CAFiP3vypf7KEmToKsBqn1--qf_PzMV+p-d9bsMj04eoYnj5_tQ@mail.gmail.com>
<CAKKotZQumWW_cvhvgyFc7_1Lvs8npkPW57FgVN_+wPPSurBDOw@mail.gmail.com>
<CAKKotZQMR5zsbDAiAhUEQ46yhNE51BONu0DYjEY1WFSJbBqK+w@mail.gmail.com>
<CAFiP3vwBUX5Ez51Fk_s+t67hRW-uZ6ViMcuTg4e+oPf+k5KqTg@mail.gmail.com>
<CAFOhELdg9-TB=fdpGDLNkjYve9vBxYttE_PzmahsrNMQv4nn4Q@mail.gmail.com>
<CAFiP3vxO9tej3WXYeLjZk6MgQYR0C-hp9UUWmog1E7iDvvqFmQ@mail.gmail.com>
<CAFOhELd=_vuqwR0eGLL=KhxGaQCP6n9mcXP1GijcWh1ecCpegw@mail.gmail.com>
<CAFiP3vw5nx2Wdt9ci-MNRV+H+dO-x9KUSZtk16EZKjdox+KRxg@mail.gmail.com>
<CAFiP3vz9=gtNuoGEt+oxt+UYfE=7=dTUQZpCxgGkVWUhS=Kafw@mail.gmail.com>
<CA+yw=mPp8CY+jd3FUXeV-KSd+82dztXYWySJVLuL9eoE9hrbfQ@mail.gmail.com>
<CAFiP3vw+yN2kYktjdmJEHL8Ug8R+k_HxhN+E+pozpC=d_zs1=Q@mail.gmail.com>
<CAKKotZQKV3nkCz8ADOV1ExoSaKWHdH4rY17xW9K3B-4qLree3Q@mail.gmail.com>
<CAKKotZTiR-cUVTbH21WnYbHW3EaQ3J_zESyYrkL+wO4sKNSSGg@mail.gmail.com>
<CAKKotZQyTOK4tZYQ2kk4_G-4GknU+uDVu3PaU5FDeJuCe=ywDw@mail.gmail.com>
<CAM5-9D9R6fT9LOhCBoSbcBvzKpWcjZvN23-wHRTJKsvQqNPECA@mail.gmail.com>
<CAFiP3vwY_cAx9b-BoxteX5+7fcxVvu+LY4y5ooy28bxvz7D8AA@mail.gmail.com>
<CAFiP3vwfO=udZvVPdXuEnem9A2LN7MBEQt02VW1AJLuCEsRL2w@mail.gmail.com>
<CANxoLDcJ-Qum-BJXtDx52ij72EJVzLE+XYFE+_skJF4fXVJ9jA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi
I just started to take a look at the table dialogue and friends. Here are a
few issues that we need to address - please take care of them:
1) Move columns to their own tab. Vertical scrolling is bad.
2) Similarly, move constraints to their own tab.
3) Ensure all labels only have a capital letter on the first word, except
if following words are keywords or acronyms, e.g.
With default values?
Has OIDs?
4) s/System tabel?/System table?
5) Error messages on fields should not be shown unless the field loses
focus and has an error (see Create Table)
6) The sections on the Properties view are not as they should be. As I've
pointed out before, the "General" section should have a limited subset of
information, e.g. name, oid, owner, tablespace, comment and "is system?"
Other properties should be in other appropriate sections.
7) Variables grids should not be on the Security tab (as also mentioned
previously).
8) Field labels that imply a question (e.g. usually those with a Yes/No
switch for input) should end in a ? - e.g. "Deferrable?"
9) On the Trigger dialogue, "Fires" and following controls should move to a
new tab.
10) On the MV dialogue, VACUUM settings should be on their own tab, as on
the Table dialogue.
11) Privileges controls on the Properties lists should be in a "Security"
group, not "General"
I think there are a couple of basic principles to follow here:
- Make properties lists and dialogues consistent with existing ones, from
control grouping right down to spelling and case of labels.
- Dialogs should never need vertical scrolling by default (e.g. for a new
object with no columns/constraints/whatever yet defined). If you need to
scroll, then things should be moved to a new tab, grouped as appropriate.
Thanks.
On Fri, May 20, 2016 at 7:57 AM, Akshay Joshi <[email protected]
> wrote:
> Thanks - Committed with minor changes.
>
> On Thu, May 19, 2016 at 10:47 PM, Harshal Dhumal <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA updated patch for table and all it's child nodes (Version 9). This
>> patch does not depend on any of existing table node patch.
>>
>> Major change in this patch: Unlike pgAdmin3 now in table create mode any
>> constraint(s) created (but not saved) will listen to table column changes
>> and adapt themselves accordingly.
>>
>> For e.g.
>> In table create mode user adds column definition with name "col1" then
>> adds constraint which includes column "col1". Now user changes column name
>> to "col2" then constraint will listen to this change and adapt the column
>> name from "col1" to "col2" in constraint definition. Also if column "col2"
>> is removed then constraint will also remove the column "col2" from it's
>> definition.
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB <http://www.enterprisedb.com;
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (49+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Tables node (pgAdmin4)
In-Reply-To: <CA+OCxowB=LJKts18wKx982gF4ZNJnOamND0xZEMp0CnTrjeruA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox