public inbox for [email protected]
help / color / mirror / Atom feed[pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL
2+ messages / 2 participants
[nested] [flat]
* [pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL
@ 2018-06-15 06:51 Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Akshay Joshi @ 2018-06-15 06:51 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is the patch for RM #3356 pgAdmin 4 does not include schema name
in generated package SQL. Please review it.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachments:
[application/octet-stream] RM_3356.patch (822B, 3-RM_3356.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
index 9aa5c9b..1013207 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
@@ -688,7 +688,7 @@ class PackageView(PGChildNodeView):
res['rows'][0].setdefault(row['deftype'], []).append(priv)
result = res['rows'][0]
- sql, name = self.getSQL(gid, sid, did, result, scid)
+ sql, name = self.getSQL(gid, sid, did, result, scid, pkgid)
# Most probably this is due to error
if not isinstance(sql, (str, unicode)):
return sql
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL
@ 2018-06-15 09:42 Dave Page <[email protected]>
parent: Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2018-06-15 09:42 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
Thanks, applied.
On Fri, Jun 15, 2018 at 7:51 AM, Akshay Joshi <[email protected]
> wrote:
> Hi Hackers,
>
> Attached is the patch for RM #3356 pgAdmin 4 does not include schema name
> in generated package SQL. Please review it.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2018-06-15 09:42 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 06:51 [pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL Akshay Joshi <[email protected]>
2018-06-15 09:42 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox